Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 2566983004: DevTools: Fix profiler private field accesses. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
index 010d83c37efd5e4aa0df8684671fa18ee7e5345c..657eb562e1ae135e48f779db27921b7fe001aa7f 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
@@ -190,7 +190,7 @@ Profiler.CPUProfileType = class extends Profiler.ProfileType {
startRecordingProfile() {
var target = UI.context.flavor(SDK.Target);
- if (this._profileBeingRecorded || !target)
+ if (this.profileBeingRecorded() || !target)
return;
var profile = new Profiler.CPUProfileHeader(target, this);
this.setProfileBeingRecorded(profile);
@@ -203,7 +203,7 @@ Profiler.CPUProfileType = class extends Profiler.ProfileType {
stopRecordingProfile() {
this._recording = false;
- if (!this._profileBeingRecorded || !this._profileBeingRecorded.target())
+ if (!this.profileBeingRecorded() || !this.profileBeingRecorded().target())
return;
var recordedProfile;
@@ -213,12 +213,12 @@ Profiler.CPUProfileType = class extends Profiler.ProfileType {
* @this {Profiler.CPUProfileType}
*/
function didStopProfiling(profile) {
- if (!this._profileBeingRecorded)
+ if (!this.profileBeingRecorded())
return;
console.assert(profile);
- this._profileBeingRecorded.setProtocolProfile(profile);
- this._profileBeingRecorded.updateStatus('');
- recordedProfile = this._profileBeingRecorded;
+ this.profileBeingRecorded().setProtocolProfile(profile);
+ this.profileBeingRecorded().updateStatus('');
+ recordedProfile = this.profileBeingRecorded();
this.setProfileBeingRecorded(null);
}
@@ -229,7 +229,7 @@ Profiler.CPUProfileType = class extends Profiler.ProfileType {
this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, recordedProfile);
}
- this._profileBeingRecorded.target()
+ this.profileBeingRecorded().target()
.cpuProfilerModel.stopRecording()
.then(didStopProfiling.bind(this))
.then(SDK.targetManager.resumeAllTargets.bind(SDK.targetManager))
@@ -332,8 +332,9 @@ Profiler.CPUFlameChartDataProvider = class extends Profiler.ProfileFlameChartDat
* @param {?SDK.Target} target
*/
constructor(cpuProfile, target) {
- super(target);
+ super();
this._cpuProfile = cpuProfile;
+ this._target = target;
}
/**

Powered by Google App Engine
This is Rietveld 408576698