Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2566983004: DevTools: Fix profiler private field accesses. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
index e10fb6625d424079abfd7204b4248301cc6033c6..bcfb271a1cae209d2149ff27eb6bb3dcdeef5715 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
@@ -97,7 +97,7 @@ Profiler.SamplingHeapProfileType = class extends Profiler.ProfileType {
startRecordingProfile() {
var target = UI.context.flavor(SDK.Target);
- if (this._profileBeingRecorded || !target)
+ if (this.profileBeingRecorded() || !target)
return;
var profile = new Profiler.SamplingHeapProfileHeader(target, this);
this.setProfileBeingRecorded(profile);
@@ -110,7 +110,7 @@ Profiler.SamplingHeapProfileType = class extends Profiler.ProfileType {
stopRecordingProfile() {
this._recording = false;
- if (!this._profileBeingRecorded || !this._profileBeingRecorded.target())
+ if (!this.profileBeingRecorded() || !this.profileBeingRecorded().target())
return;
var recordedProfile;
@@ -120,12 +120,12 @@ Profiler.SamplingHeapProfileType = class extends Profiler.ProfileType {
* @this {Profiler.SamplingHeapProfileType}
*/
function didStopProfiling(profile) {
- if (!this._profileBeingRecorded)
+ if (!this.profileBeingRecorded())
return;
console.assert(profile);
- this._profileBeingRecorded.setProtocolProfile(profile);
- this._profileBeingRecorded.updateStatus('');
- recordedProfile = this._profileBeingRecorded;
+ this.profileBeingRecorded().setProtocolProfile(profile);
+ this.profileBeingRecorded().updateStatus('');
+ recordedProfile = this.profileBeingRecorded();
this.setProfileBeingRecorded(null);
}
@@ -136,7 +136,7 @@ Profiler.SamplingHeapProfileType = class extends Profiler.ProfileType {
this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, recordedProfile);
}
- this._profileBeingRecorded.target()
+ this.profileBeingRecorded().target()
.heapProfilerModel.stopSampling()
.then(didStopProfiling.bind(this))
.then(SDK.targetManager.resumeAllTargets.bind(SDK.targetManager))
@@ -294,8 +294,9 @@ Profiler.HeapFlameChartDataProvider = class extends Profiler.ProfileFlameChartDa
* @param {?SDK.Target} target
*/
constructor(profile, target) {
- super(target);
+ super();
this._profile = profile;
+ this._target = target;
}
/**

Powered by Google App Engine
This is Rietveld 408576698