Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2566943004: IntersectionObserver: compute correct intersection ratio for 0x0 elements (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: compute correct intersection ratio for 0x0 elements When a 0x0 element is in view, its intersection ratio is defined[1] to be 1. BUG=662826 TBR=szager@chromium.org NOTRY=true NOPRESUBMIT=true [1] https://wicg.github.io/IntersectionObserver/#update-intersection-observations-algo Review-Url: https://codereview.chromium.org/2556243003 Cr-Commit-Position: refs/heads/master@{#437617} (cherry picked from commit 8296d3b0e6a755dabf607b78a259f86803699d88) Review-Url: https://codereview.chromium.org/2566943004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-hidden.html View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-visible.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Sami
Stefan, could you double-check this cherry-pick to M56? I did a local build and made ...
4 years ago (2016-12-13 10:52:35 UTC) #3
szager1
lgtm
4 years ago (2016-12-13 20:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566943004/1
4 years ago (2016-12-14 16:02:45 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-12-14 16:02:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566943004/1
4 years ago (2016-12-14 16:59:47 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 17:04:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698