Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2566923002: Made list-style-position property independent. (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
napper, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made list-style-position property independent. Made list-style-position property independent. Also updated independent-inheritance-fast-path.html to include listStylePosition. Tested using independent-inheritance-fast-path.html. BUG=628043 Committed: https://crrev.com/06340ec1a7ea945a8c0442be9cb4cb154e32aa6b Cr-Commit-Position: refs/heads/master@{#438008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
sashab
Sorry I know you like doing these but they are SO fun!! We can share ...
4 years ago (2016-12-12 03:44:12 UTC) #2
napper
lgtm
4 years ago (2016-12-12 03:55:09 UTC) #3
sashab
nainar@ rs please
4 years ago (2016-12-12 03:59:45 UTC) #5
nainar
lgtm
4 years ago (2016-12-12 04:02:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566923002/1
4 years ago (2016-12-12 04:02:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196846)
4 years ago (2016-12-12 05:55:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566923002/1
4 years ago (2016-12-13 01:51:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 03:00:46 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-13 03:02:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06340ec1a7ea945a8c0442be9cb4cb154e32aa6b
Cr-Commit-Position: refs/heads/master@{#438008}

Powered by Google App Engine
This is Rietveld 408576698