Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2566903003: Add a new target for GmsCore integration. (Closed)

Created:
4 years ago by gsennton
Modified:
4 years ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new target for GmsCore integration. Add a new target for GmsCore integration to let WebView code depend on GmsCore without depending on //android_webview/android_webview_java. Note that we don't remove PlatformServiceBridge from the android_webview_java target yet as that would break downstream. BUG=657314 Committed: https://crrev.com/296f0c8513a26026a9c1fa1912434446b07c5312 Cr-Commit-Position: refs/heads/master@{#437878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M android_webview/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gsennton
ptal :) Adding Paul as a FYI
4 years ago (2016-12-12 11:17:16 UTC) #2
Tobias Sargeant
lgtm
4 years ago (2016-12-12 13:23:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566903003/1
4 years ago (2016-12-12 14:26:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 15:34:15 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 15:36:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/296f0c8513a26026a9c1fa1912434446b07c5312
Cr-Commit-Position: refs/heads/master@{#437878}

Powered by Google App Engine
This is Rietveld 408576698