Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 25669004: Handlify JSObject::GetProperty????Interceptor. (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::GetProperty????Interceptor. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17145

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -64 lines) Patch
M src/objects.h View 1 2 2 chunks +14 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 5 chunks +58 lines, -36 lines 0 comments Download
M src/runtime.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 2 4 chunks +19 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 2 months ago (2013-10-02 13:55:04 UTC) #1
Michael Starzinger
LGTM if comments are addressed. https://codereview.chromium.org/25669004/diff/4001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/25669004/diff/4001/src/objects.cc#newcode12964 src/objects.cc:12964: Handle<JSObject> holder, nit: s/holder/object/ ...
7 years, 2 months ago (2013-10-02 18:56:24 UTC) #2
Yang
7 years, 2 months ago (2013-10-10 15:27:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698