Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/objects.h

Issue 25669004: Handlify JSObject::GetProperty????Interceptor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1438 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 // Failure is returned otherwise. 1449 // Failure is returned otherwise.
1450 MUST_USE_RESULT inline MaybeObject* ToSmi(); 1450 MUST_USE_RESULT inline MaybeObject* ToSmi();
1451 1451
1452 void Lookup(Name* name, LookupResult* result); 1452 void Lookup(Name* name, LookupResult* result);
1453 1453
1454 // Property access. 1454 // Property access.
1455 MUST_USE_RESULT inline MaybeObject* GetProperty(Name* key); 1455 MUST_USE_RESULT inline MaybeObject* GetProperty(Name* key);
1456 MUST_USE_RESULT inline MaybeObject* GetProperty( 1456 MUST_USE_RESULT inline MaybeObject* GetProperty(
1457 Name* key, 1457 Name* key,
1458 PropertyAttributes* attributes); 1458 PropertyAttributes* attributes);
1459
1460 // TODO(yangguo): this should eventually replace the non-handlified version.
1461 static Handle<Object> GetPropertyWithReceiver(Handle<Object> object,
1462 Handle<Object> receiver,
1463 Handle<Name> name,
1464 PropertyAttributes* attributes);
1459 MUST_USE_RESULT MaybeObject* GetPropertyWithReceiver( 1465 MUST_USE_RESULT MaybeObject* GetPropertyWithReceiver(
1460 Object* receiver, 1466 Object* receiver,
1461 Name* key, 1467 Name* key,
1462 PropertyAttributes* attributes); 1468 PropertyAttributes* attributes);
1463 1469
1464 static Handle<Object> GetProperty(Handle<Object> object, 1470 static Handle<Object> GetProperty(Handle<Object> object,
1465 Handle<Name> key); 1471 Handle<Name> key);
1466 static Handle<Object> GetProperty(Handle<Object> object, 1472 static Handle<Object> GetProperty(Handle<Object> object,
1467 Handle<Object> receiver, 1473 Handle<Object> receiver,
1468 LookupResult* result, 1474 LookupResult* result,
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
2235 // Defines an AccessorInfo property on the given object. 2241 // Defines an AccessorInfo property on the given object.
2236 static Handle<Object> SetAccessor(Handle<JSObject> object, 2242 static Handle<Object> SetAccessor(Handle<JSObject> object,
2237 Handle<AccessorInfo> info); 2243 Handle<AccessorInfo> info);
2238 2244
2239 // Used from Object::GetProperty(). 2245 // Used from Object::GetProperty().
2240 MUST_USE_RESULT MaybeObject* GetPropertyWithFailedAccessCheck( 2246 MUST_USE_RESULT MaybeObject* GetPropertyWithFailedAccessCheck(
2241 Object* receiver, 2247 Object* receiver,
2242 LookupResult* result, 2248 LookupResult* result,
2243 Name* name, 2249 Name* name,
2244 PropertyAttributes* attributes); 2250 PropertyAttributes* attributes);
2245 MUST_USE_RESULT MaybeObject* GetPropertyWithInterceptor( 2251 static Handle<Object> GetPropertyWithInterceptor(
2246 Object* receiver, 2252 Handle<JSObject> holder,
Michael Starzinger 2013/10/02 18:56:24 nit: s/holder/object/ for consistency.
2247 Name* name, 2253 Handle<Object> receiver,
2254 Handle<Name> name,
2248 PropertyAttributes* attributes); 2255 PropertyAttributes* attributes);
2249 MUST_USE_RESULT MaybeObject* GetPropertyPostInterceptor( 2256 static Handle<Object> GetPropertyPostInterceptor(
2250 Object* receiver, 2257 Handle<JSObject> holder,
Michael Starzinger 2013/10/02 18:56:24 nit: s/holder/object/ for consistency.
2251 Name* name, 2258 Handle<Object> receiver,
2259 Handle<Name> name,
2252 PropertyAttributes* attributes); 2260 PropertyAttributes* attributes);
2253 MUST_USE_RESULT MaybeObject* GetLocalPropertyPostInterceptor( 2261 MUST_USE_RESULT MaybeObject* GetLocalPropertyPostInterceptor(
2254 Object* receiver, 2262 Object* receiver,
2255 Name* name, 2263 Name* name,
2256 PropertyAttributes* attributes); 2264 PropertyAttributes* attributes);
2257 2265
2258 // Returns true if this is an instance of an api function and has 2266 // Returns true if this is an instance of an api function and has
2259 // been modified since it was created. May give false positives. 2267 // been modified since it was created. May give false positives.
2260 bool IsDirty(); 2268 bool IsDirty();
2261 2269
(...skipping 7972 matching lines...) Expand 10 before | Expand all | Expand 10 after
10234 } else { 10242 } else {
10235 value &= ~(1 << bit_position); 10243 value &= ~(1 << bit_position);
10236 } 10244 }
10237 return value; 10245 return value;
10238 } 10246 }
10239 }; 10247 };
10240 10248
10241 } } // namespace v8::internal 10249 } } // namespace v8::internal
10242 10250
10243 #endif // V8_OBJECTS_H_ 10251 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698