Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2566893003: Move frameBlameContext() accessor to FrameLoaderClient. (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move frameBlameContext() accessor to FrameLoaderClient. Make it clear this is only used for LocalFrames. Committed: https://crrev.com/757d33edc6bc31ef25b033c7ed02beef5be24316 Cr-Commit-Position: refs/heads/master@{#437919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dcheng
4 years ago (2016-12-12 07:24:16 UTC) #4
Sami
lgtm, thanks for the refactor.
4 years ago (2016-12-12 20:04:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566893003/1
4 years ago (2016-12-12 20:07:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 21:36:26 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 21:40:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/757d33edc6bc31ef25b033c7ed02beef5be24316
Cr-Commit-Position: refs/heads/master@{#437919}

Powered by Google App Engine
This is Rietveld 408576698