Issue 256683003: Revert 266042 "Automatically call OnNativeThemeChanged when a wi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256683003: Revert 266042 "Automatically call OnNativeThemeChanged when a wi..." (Closed)

Created:
6 years, 8 months ago by rmsousa

Modified:
6 years, 8 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 266042 "Automatically call OnNativeThemeChanged when a wi..." This seems to have broken views_unittest (label_unittest) on ChromiumOS > Automatically call OnNativeThemeChanged when a widget is added to a hierarchy > with a widget. > > Split off from https://codereview.chromium.org/245863002/ > > BUG=347832 (tangentially) > > Review URL: https://codereview.chromium.org/248073005 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266072

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -81 lines)			Patch
M	trunk/src/chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/controls/button/text_button.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/controls/label.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/controls/label.cc	View	2 chunks	+18 lines, -13 lines	0 comments	Download
M	trunk/src/ui/views/controls/scroll_view.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	trunk/src/ui/views/controls/textfield/textfield.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/controls/textfield/textfield.cc	View	3 chunks	+18 lines, -9 lines	0 comments	Download
M	trunk/src/ui/views/view.cc	View	3 chunks	+5 lines, -10 lines	0 comments	Download
M	trunk/src/ui/views/view_unittest.cc	View	4 chunks	+1 line, -46 lines	0 comments	Download

Total messages: 2 (0 generated)

rmsousa

6 years, 8 months ago (2014-04-25 00:53:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r266072 (tree was closed).