Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248073005: Automatically call OnNativeThemeChanged when a widget is added to a hierarchy (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+views_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Automatically call OnNativeThemeChanged when a widget is added to a hierarchy with a widget. Split off from https://codereview.chromium.org/245863002/ BUG=347832 (tangentially) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266042

Patch Set 1 #

Patch Set 2 : better test #

Patch Set 3 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -69 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/label.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 2 chunks +13 lines, -18 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M ui/views/view.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M ui/views/view_unittest.cc View 1 4 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
Split off from https://codereview.chromium.org/245863002/
6 years, 8 months ago (2014-04-23 23:32:19 UTC) #1
Evan Stade
Split off from https://codereview.chromium.org/245863002/
6 years, 8 months ago (2014-04-23 23:32:20 UTC) #2
sky
LGTM
6 years, 8 months ago (2014-04-24 03:11:52 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-24 04:13:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/248073005/40001
6 years, 8 months ago (2014-04-24 04:14:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 08:27:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 08:27:32 UTC) #7
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-24 17:17:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/248073005/40001
6 years, 8 months ago (2014-04-24 17:17:34 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:33:36 UTC) #10
Message was sent while issue was closed. 
Change committed as 266042

Powered by Google App Engine
This is Rietveld 408576698