Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2566813002: Revert of Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (patchset #54 id:1050001 of https://codereview.chromium.org/2493223002/ ) Reason for revert: Breaks test (DesktopMediaListAshTest.ScreenOnly) in chromeos-ozone builds. Original issue's description: > Moved exo::SurfaceFactoryOwner to its own file and renamed it to exo::CompositorFrameSink. > > CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink. > > CompositorFrameSink is no longer a friend class of exo::Surface. > > Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient. > > BUG=659601 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2493223002 TBR=reveman@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,sky@chromium.org,staraz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659601 Committed: https://crrev.com/87d78f2736ef5cd0e45387edee49b5e9c922d6cb Cr-Commit-Position: refs/heads/master@{#437753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -490 lines) Patch
M ash/test/ash_test_helper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/exo/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M components/exo/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/exo/compositor_frame_sink.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/exo/compositor_frame_sink.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D components/exo/compositor_frame_sink_holder.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/exo/compositor_frame_sink_holder.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M components/exo/surface.h View 9 chunks +56 lines, -13 lines 0 comments Download
M components/exo/surface.cc View 12 chunks +140 lines, -31 lines 0 comments Download
M components/exo/surface_unittest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M components/exo/test/run_all_unittests.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sadrul
Created Revert of Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink
4 years ago (2016-12-10 04:45:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566813002/1
4 years ago (2016-12-10 04:45:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 04:46:19 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87d78f2736ef5cd0e45387edee49b5e9c922d6cb
Cr-Commit-Position: refs/heads/master@{#437753}

Powered by Google App Engine
This is Rietveld 408576698