Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 25668008: Make Document::caretRangeFromPoint() to work with :first-letter style (Closed)

Created:
7 years, 2 months ago by yosin_UTC9
Modified:
7 years, 2 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch
Visibility:
Public.

Description

Make Document::caretRangeFromPoint() to work with :first-letter style This patch makes Document::caretRangeFromPoint() to work with :first-letter style by changing HitTestResult class to know whether specified point is in a renderer for :first-letter or not. Because of text nodes having :first-letter style are associated to two renderer, one for first letter and another is rest of text, this patch changes nodeFromPoint() to rendererFromPoint() and makes Document::caretRangeFromPoint() to use it. This patch is a part of fixing issue 174349. Another patch will make selection to work with :first-letter style. BUG=n/a TEST=LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159012

Patch Set 1 : 2013-10-04T19:04:13 #

Total comments: 1

Patch Set 2 : 2013-10-07T15:30:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -12 lines) Patch
A LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/TreeScope.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 4 chunks +5 lines, -0 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 7 chunks +17 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextFragment.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTextFragment.cpp View 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. P.S. This patch is split from https://codereview.chromium.org/20681004/ ...
7 years, 2 months ago (2013-10-04 10:13:57 UTC) #1
ojan
lgtm https://codereview.chromium.org/25668008/diff/3001/LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html File LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html (right): https://codereview.chromium.org/25668008/diff/3001/LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html#newcode32 LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-with-first-letter-style.html:32: window.jsTestIsAsync = true; This test doesn't need to ...
7 years, 2 months ago (2013-10-04 17:36:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/25668008/3001
7 years, 2 months ago (2013-10-04 17:36:32 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=6894
7 years, 2 months ago (2013-10-04 18:42:24 UTC) #4
yosin_UTC9
7 years, 2 months ago (2013-10-07 07:41:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r159012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698