Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2566793002: PPC/s390: [x86] Also deal with holey arrays in the Apply builtin. (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [x86] Also deal with holey arrays in the Apply builtin. Port d4f01b8a65ec02250c3f2b52b9a5e335ff513d98 Original Commit Message: Add fast paths for holey smi and object arrays to Function.prototype.apply, Reflect.apply and Reflect.construct. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/33e651e513dfe0a730206d7c62fb3993edafc3cf Cr-Commit-Position: refs/heads/master@{#41626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -18 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +35 lines, -9 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +35 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
JaideepBajwa
ptal
4 years ago (2016-12-10 00:33:25 UTC) #1
john.yan
lgtm
4 years ago (2016-12-10 00:57:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566793002/1
4 years ago (2016-12-10 00:58:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 01:23:27 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-10 01:24:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33e651e513dfe0a730206d7c62fb3993edafc3cf
Cr-Commit-Position: refs/heads/master@{#41626}

Powered by Google App Engine
This is Rietveld 408576698