Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 2566753002: Modify StartPhysicalWebDiscovery to take an ios::ChromeBrowserState param (Closed)

Created:
4 years ago by mattreynolds
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify StartPhysicalWebDiscovery to take an ios::ChromeBrowserState param In a future CL, the Physical Web's auto-optin behavior will be modified to require that Google is configured as the default search provider. This CL adds a new overload for StartPhysicalWebDiscovery so downstream users can be modified to use the new signature that provides access to the browser state, from which we can determine the default search provider. BUG=630769 Committed: https://crrev.com/7d1e59e370b8810d5ba953d38887ed4a79af4a5e Cr-Commit-Position: refs/heads/master@{#438003}

Patch Set 1 #

Patch Set 2 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ios/chrome/browser/physical_web/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/physical_web/start_physical_web_discovery.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ios/chrome/browser/physical_web/start_physical_web_discovery.mm View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
mattreynolds
Hi Sylvain, PTAL
4 years ago (2016-12-09 21:53:16 UTC) #2
sdefresne
lgtm
4 years ago (2016-12-11 09:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566753002/1
4 years ago (2016-12-12 18:19:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121249) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-12 18:23:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566753002/20001
4 years ago (2016-12-12 19:53:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197552)
4 years ago (2016-12-12 23:06:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566753002/20001
4 years ago (2016-12-12 23:52:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 02:53:49 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 02:56:58 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d1e59e370b8810d5ba953d38887ed4a79af4a5e
Cr-Commit-Position: refs/heads/master@{#438003}

Powered by Google App Engine
This is Rietveld 408576698