Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2566703002: Various formatting cleanups to net/quic/core/frames (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Various formatting cleanups to net/quic/core/frames and net/quic/core/congestion_control to sync with internal. Committed: https://crrev.com/84610f0ed6f2bbac8241903ae0b7e774b680aad5 Cr-Commit-Position: refs/heads/master@{#437720}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -332 lines) Patch
M net/net.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/bbr_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/cubic.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/cubic_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/pacing_sender.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/core/congestion_control/prr_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/prr_sender_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_interface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/windowed_filter_test.cc View 5 chunks +1 line, -5 lines 0 comments Download
M net/quic/core/frames/quic_ack_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/frames/quic_blocked_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_frame.h View 2 chunks +1 line, -1 line 0 comments Download
D net/quic/core/frames/quic_frame_test.cc View 1 chunk +0 lines, -274 lines 0 comments Download
A + net/quic/core/frames/quic_frames_test.cc View 1 chunk +12 lines, -1 line 0 comments Download
M net/quic/core/frames/quic_goaway_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/frames/quic_path_close_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_rst_stream_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_stop_waiting_frame.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_stream_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/frames/quic_window_update_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Ryan Hamilton
4 years ago (2016-12-09 18:14:22 UTC) #2
Zhongyi Shi
lgtm
4 years ago (2016-12-09 19:35:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566703002/1
4 years ago (2016-12-09 19:36:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/321008)
4 years ago (2016-12-09 20:04:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566703002/20001
4 years ago (2016-12-09 22:27:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-10 02:10:18 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 15:05:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84610f0ed6f2bbac8241903ae0b7e774b680aad5
Cr-Commit-Position: refs/heads/master@{#437720}

Powered by Google App Engine
This is Rietveld 408576698