Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: net/quic/core/congestion_control/windowed_filter_test.cc

Issue 2566703002: Various formatting cleanups to net/quic/core/frames (Closed)
Patch Set: Fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/congestion_control/windowed_filter_test.cc
diff --git a/net/quic/core/congestion_control/windowed_filter_test.cc b/net/quic/core/congestion_control/windowed_filter_test.cc
index cd5399b5741ace2ed799632a435d4cb202a73b41..73ef09c8f996f5f36ce459233a2971cb3cfaedbc 100644
--- a/net/quic/core/congestion_control/windowed_filter_test.cc
+++ b/net/quic/core/congestion_control/windowed_filter_test.cc
@@ -12,7 +12,6 @@
namespace net {
namespace test {
-namespace {
class WindowedFilterTest : public ::testing::Test {
public:
@@ -182,7 +181,6 @@ TEST_F(WindowedFilterTest, SampleChangesThirdBestMin) {
// Latest sample was recorded at 100ms.
QuicTime now = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(101);
windowed_min_rtt_.Update(rtt_sample, now);
- windowed_min_rtt_.Update(rtt_sample, now);
EXPECT_EQ(rtt_sample, windowed_min_rtt_.GetThirdBest());
EXPECT_EQ(QuicTime::Delta::FromMilliseconds(40),
windowed_min_rtt_.GetSecondBest());
@@ -328,7 +326,6 @@ TEST_F(WindowedFilterTest, ExpireAllMins) {
// See crbug/616957
ASSERT_LT(windowed_min_rtt_.GetThirdBest(),
QuicTime::Delta::Infinite() - QuicTime::Delta::FromMilliseconds(5));
-
// Third best min sample was recorded at 100ms, so expiry time is 199ms.
QuicTime now = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(200);
windowed_min_rtt_.Update(rtt_sample, now);
@@ -357,8 +354,8 @@ TEST_F(WindowedFilterTest, ExpireCounterBasedMax) {
WindowedFilter<uint64_t, MaxFilter<uint64_t>, uint64_t, uint64_t> max_filter(
2, 0, 0);
- // Insert 50000 at t = 1.
const uint64_t kBest = 50000;
+ // Insert 50000 at t = 1.
max_filter.Update(50000, 1);
EXPECT_EQ(kBest, max_filter.GetBest());
UpdateWithIrrelevantSamples(&max_filter, 20, 1);
@@ -387,6 +384,5 @@ TEST_F(WindowedFilterTest, ExpireCounterBasedMax) {
EXPECT_EQ(kNewBest, max_filter.GetBest());
}
-} // namespace
} // namespace test
} // namespace net
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc ('k') | net/quic/core/frames/quic_ack_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698