Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2566683002: [wasm][asm.js] Check that property keys are literals for imports. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Check that property keys are literals for imports. BUG=672785 R=titzer@chromium.org Committed: https://crrev.com/25189ffc36886cd6069a493cb07b12ac6e1f763f Cr-Commit-Position: refs/heads/master@{#41624}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
bradnelson
4 years ago (2016-12-09 14:51:16 UTC) #3
titzer
lgtm
4 years ago (2016-12-09 15:21:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566683002/1
4 years ago (2016-12-09 15:23:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30348)
4 years ago (2016-12-09 15:26:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566683002/20001
4 years ago (2016-12-09 15:32:04 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 15:58:24 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-09 15:58:46 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25189ffc36886cd6069a493cb07b12ac6e1f763f
Cr-Commit-Position: refs/heads/master@{#41624}

Powered by Google App Engine
This is Rietveld 408576698