Fix UAF on singleton service instances

Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Committed: https://crrev.com/d154b449432f6b61c320cdff0f983bf14f097227
Cr-Commit-Position: refs/heads/master@{#437737}

[Ken Rockot(use gerrit already), 2016-12-10 00:04:48]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-12-10 00:05:23]

Description was changed from

==========
Fix UAF on singletone service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton once started.

BUG=None
==========

to

==========
Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None
==========

[Ken Rockot(use gerrit already), 2016-12-10 00:05:24]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:05:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-12-10 00:16:38]

lgtm

[Ken Rockot(use gerrit already), 2016-12-10 00:18:07]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-10 00:18:09]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:07:54]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Ken Rockot(use gerrit already), 2016-12-10 02:28:39]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:29:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:31:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481336919135330, "parent_rev":
"5e94accc82b972df8882f104206adc9783ee200a", "commit_rev":
"3d40cf244f7eb62e5819848a4efd680a427730fa"}

[commit-bot: I haz the power, 2016-12-10 03:31:39]

Description was changed from

==========
Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None
==========

to

==========
Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Review-Url: https://codereview.chromium.org/2566663003
==========

[commit-bot: I haz the power, 2016-12-10 03:31:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:05:52]

Description was changed from

==========
Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Review-Url: https://codereview.chromium.org/2566663003
==========

to

==========
Fix UAF on singleton service instances

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Committed: https://crrev.com/d154b449432f6b61c320cdff0f983bf14f097227
Cr-Commit-Position: refs/heads/master@{#437737}
==========

[commit-bot: I haz the power, 2016-12-12 15:05:53]

Patchset 1 (id:??) landed as
https://crrev.com/d154b449432f6b61c320cdff0f983bf14f097227
Cr-Commit-Position: refs/heads/master@{#437737}