Better handle non-existant wrappers when intercepting writes to plugin objects

Better handle non-existant wrappers when intercepting writes to plugin objects

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org

Committed: https://crrev.com/806a7d2250a82acc584e83cf9086701f0e77cf6d
Cr-Commit-Position: refs/heads/master@{#439812}

[jochen (gone - plz use gerrit), 2016-12-09 09:33:05]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 09:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-09 09:55:09]

LGTM

[jochen (gone - plz use gerrit), 2016-12-09 09:55:38]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-12-09 09:55:39]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-12-09 09:55:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 10:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 10:28:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2016-12-20 10:37:51]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-12-20 11:50:31]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 11:50:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 11:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 11:56:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2016-12-20 14:20:27]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-12-20 14:20:28]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2566663002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-12-20 14:20:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 15:59:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482243627552600,
"parent_rev": "0307b64678a7f1cf69aa85aa6ab19688ef5fa050", "commit_rev":
"2f53f11c7477308705233e316cec093e72add0a3"}

[commit-bot: I haz the power, 2016-12-20 15:59:35]

Description was changed from

==========
Better handle non-existant wrappers when intercepting writes to plugin objects

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org
==========

to

==========
Better handle non-existant wrappers when intercepting writes to plugin objects

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2566663002
==========

[commit-bot: I haz the power, 2016-12-20 15:59:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 16:02:27]

Description was changed from

==========
Better handle non-existant wrappers when intercepting writes to plugin objects

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org

Review-Url: https://codereview.chromium.org/2566663002
==========

to

==========
Better handle non-existant wrappers when intercepting writes to plugin objects

Creating a wrapper might fire events synchronously which in turn can
modify the wrapper. There is, however, an invariant for interceptors
that if they modify their holder, they need to signal this. Therefore,
when we create a wrapper, always signal that the write happened.

BUG=670155
R=tkent@chromium.org,haraken@chromium.org

Committed: https://crrev.com/806a7d2250a82acc584e83cf9086701f0e77cf6d
Cr-Commit-Position: refs/heads/master@{#439812}
==========

[commit-bot: I haz the power, 2016-12-20 16:02:28]

Patchset 3 (id:??) landed as
https://crrev.com/806a7d2250a82acc584e83cf9086701f0e77cf6d
Cr-Commit-Position: refs/heads/master@{#439812}