Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2566623004: CheckHasServiceWorkerCallback always called on the UI thread (Closed)

Created:
4 years ago by droger
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CheckHasServiceWorkerCallback always called on the UI thread This updates the code to match the documentation in service_worker_context.h. BUG=591427 Committed: https://crrev.com/347362dc1067fdee8a0b512bf24659ae5b8dced6 Cr-Commit-Position: refs/heads/master@{#437531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
droger
4 years ago (2016-12-09 11:14:23 UTC) #4
falken
lgtm, thanks
4 years ago (2016-12-09 13:51:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566623004/1
4 years ago (2016-12-09 14:12:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 14:16:35 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 14:18:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/347362dc1067fdee8a0b512bf24659ae5b8dced6
Cr-Commit-Position: refs/heads/master@{#437531}

Powered by Google App Engine
This is Rietveld 408576698