[4/5] Add translated rasterization support for PictureLayerTilingSet & below

[4/5] Add translated rasterization support for PictureLayerTilingSet & below

This CL extends PictureLayerTiling to support tiles rasterized with scale and
translation. Tilings still use only the scale factor as their key. It is an
error to have tilings with the same scale but a different translation in the
same PictureLayerTilingSet. This CL implements a policy to evict old tiling
when syncing from a tiling set with a slot conflict.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566613002
Cr-Commit-Position: refs/heads/master@{#463022}
Committed: https://chromium.googlesource.com/chromium/src/+/45739334a54b563922c9af81bfa2519787d453fa

[trchen, 2016-12-09 02:59:17]

Description was changed from

==========
[4/6] Add translated rasterization support for PictureLayerTilingSet & below
==========

to

==========
[4/6] Add translated rasterization support for PictureLayerTilingSet & below
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-01-03 22:53:52]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2017-01-03 22:53:53]

More testing!

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:416: gfx::RectF content_rect =
coverage_to_content_.TransformRect(gfx::RectF(coverage_rect_));
Iterator changes definitely need unit tests.

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.cc:89: if (this_tiling &&
this_tiling->raster_transform() != raster_transform) {
This could use some unit testing too.

[trchen, 2017-03-28 21:42:51]

Description was changed from

==========
[4/6] Add translated rasterization support for PictureLayerTilingSet & below
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[4/5] Add translated rasterization support for PictureLayerTilingSet & below
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[trchen, 2017-03-28 21:44:01]

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:416: gfx::RectF content_rect =
coverage_to_content_.TransformRect(gfx::RectF(coverage_rect_));
On 2017/01/03 22:53:53, enne wrote:
> Iterator changes definitely need unit tests.

Done.

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/2566613002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling_set.cc:89: if (this_tiling &&
this_tiling->raster_transform() != raster_transform) {
On 2017/01/03 22:53:53, enne wrote:
> This could use some unit testing too.

Done.

[trchen, 2017-03-28 22:59:13]

Description was changed from

==========
[4/5] Add translated rasterization support for PictureLayerTilingSet & below
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[4/5] Add translated rasterization support for PictureLayerTilingSet & below

This CL extends PictureLayerTiling to support tiles rasterized with scale and
translation. Tilings still use only the scale factor as their key. It is an
error to have tilings with the same scale but a different translation in the
same PictureLayerTilingSet. This CL implements a policy to evict old tiling
when syncing from a tiling set with a slot conflict.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-03-29 12:57:37]

lgtm % request for comments

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
cc/tiles/picture_layer_tiling.cc:47:
DCHECK_GE(raster_transform.translation().x(), 0.f);
Can you leave a comment about this restriction in the header by where the raster
transform is passed in?

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
File cc/tiles/picture_layer_tiling.h (right):

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
cc/tiles/picture_layer_tiling.h:124: float contents_scale_key() const { return
raster_transform_.scale(); }
Can you leave some more documentation here about how key relates to everything
else? I think this might be confusing to people who aren't familiar with these
classes.  Maybe at least saying that tilings have a unique scale, and then also
have a fixed translation to adjust for pixel alignment.  And also maybe that we
don't ever have tilings with the same scale and different translations, so the
scale itself can be used as the key to identify the tiling?

[trchen, 2017-03-30 22:17:32]

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
cc/tiles/picture_layer_tiling.cc:47:
DCHECK_GE(raster_transform.translation().x(), 0.f);
On 2017/03/29 12:57:37, enne wrote:
> Can you leave a comment about this restriction in the header by where the
raster
> transform is passed in?

Done.

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
File cc/tiles/picture_layer_tiling.h (right):

https://codereview.chromium.org/2566613002/diff/20001/cc/tiles/picture_layer_...
cc/tiles/picture_layer_tiling.h:124: float contents_scale_key() const { return
raster_transform_.scale(); }
On 2017/03/29 12:57:37, enne wrote:
> Can you leave some more documentation here about how key relates to everything
> else? I think this might be confusing to people who aren't familiar with these
> classes.  Maybe at least saying that tilings have a unique scale, and then
also
> have a fixed translation to adjust for pixel alignment.  And also maybe that
we
> don't ever have tilings with the same scale and different translations, so the
> scale itself can be used as the key to identify the tiling?

Done.

[trchen, 2017-04-04 17:35:00]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-04-04 17:35:00]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2566613002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-04 17:35:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 19:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:05:03]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[trchen, 2017-04-04 23:24:38]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2017-04-04 23:25:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:07:55]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[trchen, 2017-04-05 20:43:45]

The layout test failure was some rounding difference in texture sampling (pics
uploaded). Likely due to x / scale != x * (1 / scale) somewhere in coverage
iterator code. I think it is harmless.

[trchen, 2017-04-05 20:43:59]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-04-05 20:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2566613002/#ps100001
(title: "rebaseline test")

[commit-bot: I haz the power, 2017-04-05 20:44:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:50:32]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2017-04-05 21:54:22]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:08:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2017-04-05 23:09:56]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:10:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:29:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2017-04-07 04:57:14]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-04-07 04:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2566613002/#ps120001
(title: "rebase && 1 more test expectation")

[commit-bot: I haz the power, 2017-04-07 04:57:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:46:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2017-04-07 20:06:56]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-04-07 20:06:56]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2566613002/#ps140001
(title: "still need that rebaseline")

[commit-bot: I haz the power, 2017-04-07 20:07:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491595616124930,
"parent_rev": "6fb89ced75c50e77bc5c6a29bb820534d16d5279", "commit_rev":
"45739334a54b563922c9af81bfa2519787d453fa"}

[commit-bot: I haz the power, 2017-04-07 22:36:26]

Description was changed from

==========
[4/5] Add translated rasterization support for PictureLayerTilingSet & below

This CL extends PictureLayerTiling to support tiles rasterized with scale and
translation. Tilings still use only the scale factor as their key. It is an
error to have tilings with the same scale but a different translation in the
same PictureLayerTilingSet. This CL implements a policy to evict old tiling
when syncing from a tiling set with a slot conflict.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[4/5] Add translated rasterization support for PictureLayerTilingSet & below

This CL extends PictureLayerTiling to support tiles rasterized with scale and
translation. Tilings still use only the scale factor as their key. It is an
error to have tilings with the same scale but a different translation in the
same PictureLayerTilingSet. This CL implements a policy to evict old tiling
when syncing from a tiling set with a slot conflict.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566613002
Cr-Commit-Position: refs/heads/master@{#463022}
Committed:
https://chromium.googlesource.com/chromium/src/+/45739334a54b563922c9af81bfa2...
==========

[commit-bot: I haz the power, 2017-04-07 22:36:27]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/45739334a54b563922c9af81bfa2...