cc: Add a tile manager check to try and diagnose renderer hangs.

cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/b1589cc2833b4803559137acd14357e1e3a87d31
Cr-Commit-Position: refs/heads/master@{#437952}

[vmpstr, 2016-12-09 23:38:23]

Description was changed from

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
==========

to

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2016-12-09 23:38:54]

Behold, a patch!

[ericrk, 2016-12-10 01:18:40]

lgtm

[sunnyps, 2016-12-10 01:29:47]

https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc
File cc/tiles/tile_manager.cc (right):

https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc#ne...
cc/tiles/tile_manager.cc:1075: // TODO(vmpstr): Check to debug crbug.com/622080.
Remove when fixed.
Shouldn't we do this check only for the required for activation queue?

[vmpstr, 2016-12-10 01:32:47]

On 2016/12/10 01:29:47, sunnyps OOO back on Jan 3 wrote:
> https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc
> File cc/tiles/tile_manager.cc (right):
> 
>
https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc#ne...
> cc/tiles/tile_manager.cc:1075: // TODO(vmpstr): Check to debug
crbug.com/622080.
> Remove when fixed.
> Shouldn't we do this check only for the required for activation queue?

Required for draw tiles would also have to all be from the NOW bin

[ericrk, 2016-12-10 01:44:51]

On 2016/12/10 01:32:47, vmpstr wrote:
> On 2016/12/10 01:29:47, sunnyps OOO back on Jan 3 wrote:
> > https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc
> > File cc/tiles/tile_manager.cc (right):
> > 
> >
>
https://codereview.chromium.org/2566603004/diff/1/cc/tiles/tile_manager.cc#ne...
> > cc/tiles/tile_manager.cc:1075: // TODO(vmpstr): Check to debug
> crbug.com/622080.
> > Remove when fixed.
> > Shouldn't we do this check only for the required for activation queue?
> 
> Required for draw tiles would also have to all be from the NOW bin

So it sounds like crbug.com/594851 is obsolete (or was never a thing, I think it
was just a suspicion from looking at code). I'll close it out if we don't end up
hitting this CHECK.

[vmpstr, 2016-12-12 19:14:18]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-12-12 19:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:21:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481570058195360, "parent_rev":
"6a2ce6beaa707d3f59280ae552e323a76e225f86", "commit_rev":
"b3e21b4ad351e59537462f320e9e44b8ba95c8eb"}

[commit-bot: I haz the power, 2016-12-12 23:21:55]

Description was changed from

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566603004
==========

[commit-bot: I haz the power, 2016-12-12 23:21:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 23:26:05]

Description was changed from

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566603004
==========

to

==========
cc: Add a tile manager check to try and diagnose renderer hangs.

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/b1589cc2833b4803559137acd14357e1e3a87d31
Cr-Commit-Position: refs/heads/master@{#437952}
==========

[commit-bot: I haz the power, 2016-12-12 23:26:06]

Patchset 1 (id:??) landed as
https://crrev.com/b1589cc2833b4803559137acd14357e1e3a87d31
Cr-Commit-Position: refs/heads/master@{#437952}