Issue 25666014: Remove the ENABLE_GPU #define and enable_gpu gyp variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25666014: Remove the ENABLE_GPU #define and enable_gpu gyp variable (Closed)

Created:
7 years, 2 months ago by jamesr

Modified:
7 years, 2 months ago

Reviewers:
piman

CC:
chromium-reviews, jbauman+watch_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the ENABLE_GPU #define and enable_gpu gyp variable It doesn't make any sense to configure chromium without a gpu and (unsurprisingly) trying to set this variable to false just results in a broken build. R=piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226964

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -47 lines)			Patch
M	build/common.gypi	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	content/common/gpu/gpu_channel.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/common/gpu/gpu_channel.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager_client.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager_client.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/content_common.gypi	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	content/content_renderer.gypi	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/gn/secondary/build/config/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/25666014/1

7 years, 2 months ago (2013-10-03 21:45:47 UTC) #3

Message was sent while issue was closed.

Change committed as 226964

Expand Messages | Collapse Messages