Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2566593002: Change handling of sub-pixel borders to round

Created:
4 years ago by eae
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change handling of sub-pixel borders to round Change sub-pixel border handling to round to the nearest integer pixel value as opposed to always flooring. This matches how Gecko handle sub-pixel borders and is more consistent with how other sub-pixel values are rounded or pixelSnapped. TEST=fast/sub-pixel/sub-pixel-border.html BUG=671008 R=pdr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Change border images to round edges #

Messages

Total messages: 16 (13 generated)
eae
Needs a couple of updated ref tests, some new rebaselines and a fix to make ...
4 years ago (2016-12-09 04:34:11 UTC) #9
pdr.
On 2016/12/09 at 04:34:11, eae wrote: > Needs a couple of updated ref tests, some ...
4 years ago (2016-12-12 20:51:37 UTC) #15
eae
4 years ago (2016-12-12 23:59:28 UTC) #16
Thanks, it's not ready for detailed review yet though as you correctly surmised.
Will let you know!

Powered by Google App Engine
This is Rietveld 408576698