Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2566583004: Allow 'Alt+Shift+K' to show IME menu at login or lock screen. (Closed)

Created:
4 years ago by Azure Wei
Modified:
4 years ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow 'Alt+Shift+K' to show IME menu at login or lock screen. Add accelerator SHOW_IME_MENU_BUBBLE into table kActionsAllowedAtLoginOrLockScreen to allow using 'Alt+Shift+K' to open opt-in IME menu in login or lock screen. BUG=668394, 642423 TEST=Verified on local build. Committed: https://crrev.com/7b5dd2880043c9dc9ca124c5623315713873696a Cr-Commit-Position: refs/heads/master@{#437978}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/common/accelerators/accelerator_table.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Azure Wei
Please review this CL. Thanks!
4 years ago (2016-12-10 11:07:39 UTC) #3
James Cook
lgtm
4 years ago (2016-12-12 16:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566583004/20001
4 years ago (2016-12-12 23:35:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 01:26:46 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 01:29:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b5dd2880043c9dc9ca124c5623315713873696a
Cr-Commit-Position: refs/heads/master@{#437978}

Powered by Google App Engine
This is Rietveld 408576698