Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2566583003: Revert of re-enabled netlog viewer dev server tests (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
Reviewers:
sullivan, wangyix
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of re-enabled netlog viewer dev server tests (patchset #2 id:20001 of https://codereview.chromium.org/2553213002/ ) Reason for revert: Netlog test is failing, blocking catapult CQ: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/5929/steps/NetLog%20Viewer%20Dev%20Server%20Tests/logs/stdio Original issue's description: > re-enabled netlog viewer dev server tests > > BUG=catapult:#2702 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0b2f00a285c60fa162112bcc0681549e90f4e267 TBR=sullivan@chromium.org,wangyix@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#2702 Review-Url: https://codereview.chromium.org/2566583003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/19565fdb148afc5fc752516f395f715f5d27c1f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M catapult_build/build_steps.py View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of re-enabled netlog viewer dev server tests
4 years ago (2016-12-09 23:42:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566583003/1
4 years ago (2016-12-09 23:43:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/19565fdb148afc5fc752516f395f715f5d27c1f1
4 years ago (2016-12-10 00:14:02 UTC) #6
nednguyen
4 years ago (2016-12-10 00:17:00 UTC) #7
Message was sent while issue was closed. 
On 2016/12/10 00:14:02, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

In case log expires:

ERROR:root:Tests failed!
ERROR:root:Server stderr:
ERROR:root:EXCEPT  netlog_viewer.events_view_test.netInternalsEventsViewFilter
TypeError: Cannot read property 'offsetWidth' of null
    at TabSwitcherView
(http://localhost:50631/netlog_viewer/tab_switcher_view.js:43:40)
    at MainView.initTabs_ (http://localhost:50631/netlog_viewer/main.js:148:27)
    at MainView (http://localhost:50631/netlog_viewer/main.js:68:10)
    at Function.ctor.getInstance
(http://localhost:50631/netlog_viewer/cr.js:298:50)
    at TestCase.testFn_
(http://localhost:50631/netlog_viewer/events_view_test.html:108:14)
    at TestCase.run
(http://localhost:50631/tracing/base/unittest/test_case.html:79:19)
    at TestRunner.<anonymous>
(http://localhost:50631/tracing/base/unittest/test_runner.html:218:52)
    at TestRunner.runCurrentTestCase_
(http://localhost:50631/tracing/base/unittest/test_runner.html:216:14)
    at TestRunner.runOneTestCase_
(http://localhost:50631/tracing/base/unittest/test_runner.html:169:12)
FAILED  netlog_viewer.events_view_test.netInternalsEventsViewFilter 
EXCEPT  netlog_viewer.main_test.netInternalsTourTabs Error: The class MainView
is a singleton, and should only be accessed using MainView.getInstance().
    at assertFirstConstructorCall
(http://localhost:50631/netlog_viewer/util.js:167:11)
    at MainView (http://localhost:50631/netlog_viewer/main.js:53:5)
    at Function.ctor.getInstance
(http://localhost:50631/netlog_viewer/cr.js:298:50)
    at Function.NetInternalsTest.getActiveTabId
(http://localhost:50631/netlog_viewer/net_internals_test.js:283:21)
    at Function.NetInternalsTest.checkTabLinkVisibility
(http://localhost:50631/netlog_viewer/net_internals_test.js:372:37)
    at TestCase.testFn_
(http://localhost:50631/netlog_viewer/main_test.html:34:22)
    at TestCase.run
(http://localhost:50631/tracing/base/unittest/test_case.html:79:19)
    at TestRunner.<anonymous>
(http://localhost:50631/tracing/base/unittest/test_runner.html:218:52)
    at TestRunner.runCurrentTestCase_
(http://localhost:50631/tracing/base/unittest/test_runner.html:216:14)
    at TestRunner.runOneTestCase_
(http://localhost:50631/tracing/base/unittest/test_runner.html:169:12)
FAILED  netlog_viewer.main_test.netInternalsTourTabs 

ERROR:root:Server stdout:
ERROR:root:PASSED 
netlog_viewer.log_view_painter_test.netInternalsLogViewPainterStripInfo 
PASSED 
netlog_viewer.log_view_painter_test.netInternalsLogViewPainterStripGoAway 
PASSED 
netlog_viewer.log_view_painter_test.netInternalsLogViewPainterPrintAsText 
HAD_FAILURES
Passed tests: 3  Failed tests: 2  Flaky tests: 0

Powered by Google App Engine
This is Rietveld 408576698