DevTools: Do not lint front_end/protocol_externs.js.

DevTools: Do not lint front_end/protocol_externs.js.
This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam

Committed: https://crrev.com/02f72919bf98093b7c60b06112d1150099fbe7c1
Cr-Commit-Position: refs/heads/master@{#437991}

[kdzwinel, 2016-12-08 22:52:24]

PTAL

[chenwilliam, 2016-12-08 23:47:58]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-12-08 23:47:59]

Thanks for the patch. I think this happens when you're running
"compile_frontend.py" (the closure compiler typecheck) which generates
protocol_externs.js and then you run eslint while closure is running and
compile_frontend.py hasn't deleted the generated file yet. A cleaner approach
might be to generate the protocol externs file outside of front_end (e.g.
devtools/ or devtools/.generated). It's on my to-do list to clean up the
.eslintignore file since Pavel suggested we can use the "skip_compilation"
property in module.json to automatically exclude files from linting. In short, I
think this is a good quick solution.

+dgozman since I'm not an owner.

[kdzwinel, 2016-12-08 23:58:44]

On 2016/12/08 at 23:47:59, chenwilliam wrote:
> Thanks for the patch. I think this happens when you're running
"compile_frontend.py" (the closure compiler typecheck) which generates
protocol_externs.js and then you run eslint while closure is running and
compile_frontend.py hasn't deleted the generated file yet. A cleaner approach
might be to generate the protocol externs file outside of front_end (e.g.
devtools/ or devtools/.generated). It's on my to-do list to clean up the
.eslintignore file since Pavel suggested we can use the "skip_compilation"
property in module.json to automatically exclude files from linting. In short, I
think this is a good quick solution.
> 
> +dgozman since I'm not an owner.

Ah, you are correct! There was `protocol_externs.js` left in my folder after
aborted closure compilation.

Thank you for all the information.

[dgozman, 2016-12-09 00:07:01]

lgtm

[chenwilliam, 2016-12-09 19:13:59]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:49:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chenwilliam, 2016-12-09 21:41:17]

On 2016/12/09 20:49:27, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

@kdzwinel - Please add yourself to the AUTHORS file and sign the CLA. Thanks! 

"If you are a new contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA."

[kdzwinel, 2016-12-09 23:09:37]

On 2016/12/09 at 21:41:17, chenwilliam wrote:
> On 2016/12/09 20:49:27, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> @kdzwinel - Please add yourself to the AUTHORS file and sign the CLA. Thanks! 
> 
> "If you are a new contributor, please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
section
> If you are a chromite, verify the contributor signed the CLA."

Updated, thanks!

[chenwilliam, 2016-12-13 00:00:47]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-12-13 00:00:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2566553002/#ps20001
(title: "Add myself to the AUTHORS file")

[commit-bot: I haz the power, 2016-12-13 00:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:31:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481587247552030,
"parent_rev": "808c7297de83582bd9faa0cfab62c7b811e5d977", "commit_rev":
"a5934002d2c02c7bcb676744d8f0fbe8db79ad6f"}

[commit-bot: I haz the power, 2016-12-13 02:31:51]

Description was changed from

==========
DevTools: Do not lint front_end/protocol_externs.js.
This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam
==========

to

==========
DevTools: Do not lint front_end/protocol_externs.js.
This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam

Review-Url: https://codereview.chromium.org/2566553002
==========

[commit-bot: I haz the power, 2016-12-13 02:31:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 02:34:22]

Description was changed from

==========
DevTools: Do not lint front_end/protocol_externs.js.
This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam

Review-Url: https://codereview.chromium.org/2566553002
==========

to

==========
DevTools: Do not lint front_end/protocol_externs.js.
This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam

Committed: https://crrev.com/02f72919bf98093b7c60b06112d1150099fbe7c1
Cr-Commit-Position: refs/heads/master@{#437991}
==========

[commit-bot: I haz the power, 2016-12-13 02:34:22]

Patchset 2 (id:??) landed as
https://crrev.com/02f72919bf98093b7c60b06112d1150099fbe7c1
Cr-Commit-Position: refs/heads/master@{#437991}