Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256653004: Always include debugger support. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Always include debugger support. Motivation: we do not have test coverage for debuggersupport=off. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20969

Patch Set 1 #

Patch Set 2 : Makefile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -494 lines) Patch
M Makefile View 1 1 chunk +0 lines, -4 lines 0 comments Download
M build/features.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M samples/lineprocessor.cc View 10 chunks +0 lines, -14 lines 0 comments Download
M src/api.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/debug-arm.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/debug-arm64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/assembler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/assembler.cc View 6 chunks +0 lines, -14 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/builtins.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler.cc View 6 chunks +0 lines, -12 lines 0 comments Download
M src/d8.h View 8 chunks +9 lines, -11 lines 0 comments Download
M src/d8.cc View 29 chunks +34 lines, -44 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/debug.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/debug.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/debug-agent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/debug-agent.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/deoptimizer.h View 6 chunks +1 line, -10 lines 0 comments Download
M src/deoptimizer.cc View 8 chunks +1 line, -11 lines 0 comments Download
M src/execution.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/execution.cc View 7 chunks +2 lines, -16 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 5 chunks +0 lines, -12 lines 0 comments Download
M src/heap.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ic-inl.h View 4 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.h View 6 chunks +2 lines, -19 lines 0 comments Download
M src/isolate.cc View 8 chunks +0 lines, -14 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/liveedit.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/liveedit.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/debug-mips.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.h View 5 chunks +2 lines, -18 lines 0 comments Download
M src/objects.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/runtime.cc View 6 chunks +0 lines, -13 lines 0 comments Download
M src/serialize.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M src/v8threads.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-liveedit.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/oom_dump/oom_dump.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 8 months ago (2014-04-25 08:34:10 UTC) #1
Jakob Kummerow
Yay, delete ALL the code! LGTM with a comment: please update the Makefile too (debuggersupport=off ...
6 years, 8 months ago (2014-04-25 09:01:17 UTC) #2
Yang
6 years, 8 months ago (2014-04-25 11:01:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r20969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698