Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2566513003: [Mac] Remove unused ImportProgressDialog.xib and Panel.xib. (Closed)

Created:
4 years ago by Robert Sesek
Modified:
4 years ago
Reviewers:
tapted
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove unused ImportProgressDialog.xib and Panel.xib. BUG=none R=tapted@chromium.org Committed: https://crrev.com/810bce4c315a9f9c9a0c78d58ed87d6a24faf10f Cr-Commit-Position: refs/heads/master@{#438048}

Patch Set 1 #

Total comments: 4

Patch Set 2 : DELETE MOAR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -278 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/app/nibs/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/app/nibs/ImportProgressDialog.xib View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/app/nibs/Panel.xib View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Robert Sesek
4 years ago (2016-12-09 19:31:46 UTC) #3
tapted
whoo! lgtm with the grd updates https://codereview.chromium.org/2566513003/diff/1/chrome/app/nibs/ImportProgressDialog.xib File chrome/app/nibs/ImportProgressDialog.xib (left): https://codereview.chromium.org/2566513003/diff/1/chrome/app/nibs/ImportProgressDialog.xib#oldcode16 chrome/app/nibs/ImportProgressDialog.xib:16: <window title="^IDS_IMPORT_PROGRESS_TITLE" allowsToolTipsWhenApplicationIsInactive="NO" ...
4 years ago (2016-12-11 23:04:49 UTC) #6
Robert Sesek
https://codereview.chromium.org/2566513003/diff/1/chrome/app/nibs/ImportProgressDialog.xib File chrome/app/nibs/ImportProgressDialog.xib (left): https://codereview.chromium.org/2566513003/diff/1/chrome/app/nibs/ImportProgressDialog.xib#oldcode16 chrome/app/nibs/ImportProgressDialog.xib:16: <window title="^IDS_IMPORT_PROGRESS_TITLE" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" oneShot="NO" showsToolbarButton="NO" visibleAtLaunch="NO" animationBehavior="default" id="1"> ...
4 years ago (2016-12-12 17:25:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566513003/20001
4 years ago (2016-12-12 17:26:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/277948)
4 years ago (2016-12-13 02:04:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566513003/20001
4 years ago (2016-12-13 02:42:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:57:50 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 04:00:14 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/810bce4c315a9f9c9a0c78d58ed87d6a24faf10f
Cr-Commit-Position: refs/heads/master@{#438048}

Powered by Google App Engine
This is Rietveld 408576698