Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Flip quic flags by 12/12/2016 18:30 PST
https://codereview.chromium.org/2569703003/

relnote: Protected by --quic_fix_beta_last_max. Fix conservative decrease for n-connection emulation.
Merge internal change: 141565085
https://codereview.chromium.org/2569723004

relnote: Allow changing initial flow control window via connection options. Protected by --quic_large_ifw_options. Partially reverts internal change: 128225749
Merge internal change: 141507430
https://codereview.chromium.org/2569113002

rel-note: automated rollback of internal change 138108562
Merge internal change: 141469809
https://codereview.chromium.org/2566943003

relnote: Use event_time instead of ApproximateNow() in QUIC cubic code. Protected by --quic_use_event_time
Merge internal change: 141384938
https://codereview.chromium.org/2571643002

relnote: Remove unused QuicClock member of BbrSender.
Merge internal change: 141366593
https://codereview.chromium.org/2566333002

relnote: Non-functional change. Cleanup pg3 support for quic_packet_reader
Bring it more inline with Chromium source but cleanup the definition of
MMSG_MORE macro to exist in the header so that there's no violation of
ODR for QUicPacketReader class based upon inclusion.
Merge internal change: 141357226
https://codereview.chromium.org/2570703002

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes Quantization. iDue to an unfortunate ordering of operations in the actual "cubing" part of the CWND calculation, we were inadvertantly quantizing the congestion-window calculation.  (Note: The "reno" part of the cubic algorithm wis smooth and not quantized before.)  Switching the order of operations obviates the problem.
Additionally, removed parameterization from cubic_test.cc and
cubic_bytes_test.cc, because the parameterization was getting
unwieldy.  Instead, the parameters are controlled by command-line
flag.
Merge internal change: 141183279
https://codereview.chromium.org/2569873002/

BUG=

Committed: https://crrev.com/1a596c8723eb979ec597e99d27a139cf4e1f6e91
Cr-Commit-Position: refs/heads/master@{#438069}

[Zhongyi Shi, 2016-12-13 02:41:43]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[Zhongyi Shi, 2016-12-13 02:41:57]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 03:54:17]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-12-13 03:55:22]

looks good other than flag flips

[Ryan Hamilton, 2016-12-13 05:40:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-12-13 05:40:41]

lgtm

[commit-bot: I haz the power, 2016-12-13 05:41:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 05:46:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481607641023900,
"parent_rev": "092a280d5b7b32035b74f5d4d02fe1dca045eccd", "commit_rev":
"bbc6fdf9a02cbf6b1dec1cf378f272264c04c2e4"}

[commit-bot: I haz the power, 2016-12-13 05:46:34]

Description was changed from

==========
Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Flip quic flags by 12/12/2016 18:30 PST
https://codereview.chromium.org/2569703003/

relnote: Protected by --quic_fix_beta_last_max. Fix conservative decrease for
n-connection emulation.
Merge internal change: 141565085
https://codereview.chromium.org/2569723004

relnote: Allow changing initial flow control window via connection options.
Protected by --quic_large_ifw_options. Partially reverts internal change:
128225749
Merge internal change: 141507430
https://codereview.chromium.org/2569113002

rel-note: automated rollback of internal change 138108562
Merge internal change: 141469809
https://codereview.chromium.org/2566943003

relnote: Use event_time instead of ApproximateNow() in QUIC cubic code.
Protected by --quic_use_event_time
Merge internal change: 141384938
https://codereview.chromium.org/2571643002

relnote: Remove unused QuicClock member of BbrSender.
Merge internal change: 141366593
https://codereview.chromium.org/2566333002

relnote: Non-functional change. Cleanup pg3 support for quic_packet_reader
Bring it more inline with Chromium source but cleanup the definition of
MMSG_MORE macro to exist in the header so that there's no violation of
ODR for QUicPacketReader class based upon inclusion.
Merge internal change: 141357226
https://codereview.chromium.org/2570703002

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes
Quantization. iDue to an unfortunate ordering of operations in the actual
"cubing" part of the CWND calculation, we were inadvertantly quantizing the
congestion-window calculation.  (Note: The "reno" part of the cubic algorithm
wis smooth and not quantized before.)  Switching the order of operations
obviates the problem.
Additionally, removed parameterization from cubic_test.cc and
cubic_bytes_test.cc, because the parameterization was getting
unwieldy.  Instead, the parameters are controlled by command-line
flag.
Merge internal change: 141183279
https://codereview.chromium.org/2569873002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Flip quic flags by 12/12/2016 18:30 PST
https://codereview.chromium.org/2569703003/

relnote: Protected by --quic_fix_beta_last_max. Fix conservative decrease for
n-connection emulation.
Merge internal change: 141565085
https://codereview.chromium.org/2569723004

relnote: Allow changing initial flow control window via connection options.
Protected by --quic_large_ifw_options. Partially reverts internal change:
128225749
Merge internal change: 141507430
https://codereview.chromium.org/2569113002

rel-note: automated rollback of internal change 138108562
Merge internal change: 141469809
https://codereview.chromium.org/2566943003

relnote: Use event_time instead of ApproximateNow() in QUIC cubic code.
Protected by --quic_use_event_time
Merge internal change: 141384938
https://codereview.chromium.org/2571643002

relnote: Remove unused QuicClock member of BbrSender.
Merge internal change: 141366593
https://codereview.chromium.org/2566333002

relnote: Non-functional change. Cleanup pg3 support for quic_packet_reader
Bring it more inline with Chromium source but cleanup the definition of
MMSG_MORE macro to exist in the header so that there's no violation of
ODR for QUicPacketReader class based upon inclusion.
Merge internal change: 141357226
https://codereview.chromium.org/2570703002

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes
Quantization. iDue to an unfortunate ordering of operations in the actual
"cubing" part of the CWND calculation, we were inadvertantly quantizing the
congestion-window calculation.  (Note: The "reno" part of the cubic algorithm
wis smooth and not quantized before.)  Switching the order of operations
obviates the problem.
Additionally, removed parameterization from cubic_test.cc and
cubic_bytes_test.cc, because the parameterization was getting
unwieldy.  Instead, the parameters are controlled by command-line
flag.
Merge internal change: 141183279
https://codereview.chromium.org/2569873002/

BUG=

Review-Url: https://codereview.chromium.org/2566403002
==========

[commit-bot: I haz the power, 2016-12-13 05:46:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 05:49:08]

Description was changed from

==========
Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Flip quic flags by 12/12/2016 18:30 PST
https://codereview.chromium.org/2569703003/

relnote: Protected by --quic_fix_beta_last_max. Fix conservative decrease for
n-connection emulation.
Merge internal change: 141565085
https://codereview.chromium.org/2569723004

relnote: Allow changing initial flow control window via connection options.
Protected by --quic_large_ifw_options. Partially reverts internal change:
128225749
Merge internal change: 141507430
https://codereview.chromium.org/2569113002

rel-note: automated rollback of internal change 138108562
Merge internal change: 141469809
https://codereview.chromium.org/2566943003

relnote: Use event_time instead of ApproximateNow() in QUIC cubic code.
Protected by --quic_use_event_time
Merge internal change: 141384938
https://codereview.chromium.org/2571643002

relnote: Remove unused QuicClock member of BbrSender.
Merge internal change: 141366593
https://codereview.chromium.org/2566333002

relnote: Non-functional change. Cleanup pg3 support for quic_packet_reader
Bring it more inline with Chromium source but cleanup the definition of
MMSG_MORE macro to exist in the header so that there's no violation of
ODR for QUicPacketReader class based upon inclusion.
Merge internal change: 141357226
https://codereview.chromium.org/2570703002

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes
Quantization. iDue to an unfortunate ordering of operations in the actual
"cubing" part of the CWND calculation, we were inadvertantly quantizing the
congestion-window calculation.  (Note: The "reno" part of the cubic algorithm
wis smooth and not quantized before.)  Switching the order of operations
obviates the problem.
Additionally, removed parameterization from cubic_test.cc and
cubic_bytes_test.cc, because the parameterization was getting
unwieldy.  Instead, the parameters are controlled by command-line
flag.
Merge internal change: 141183279
https://codereview.chromium.org/2569873002/

BUG=

Review-Url: https://codereview.chromium.org/2566403002
==========

to

==========
Landing Recent QUIC changes until 3:47 pm, Dec 10, 2016 UTC-8

Flip quic flags by 12/12/2016 18:30 PST
https://codereview.chromium.org/2569703003/

relnote: Protected by --quic_fix_beta_last_max. Fix conservative decrease for
n-connection emulation.
Merge internal change: 141565085
https://codereview.chromium.org/2569723004

relnote: Allow changing initial flow control window via connection options.
Protected by --quic_large_ifw_options. Partially reverts internal change:
128225749
Merge internal change: 141507430
https://codereview.chromium.org/2569113002

rel-note: automated rollback of internal change 138108562
Merge internal change: 141469809
https://codereview.chromium.org/2566943003

relnote: Use event_time instead of ApproximateNow() in QUIC cubic code.
Protected by --quic_use_event_time
Merge internal change: 141384938
https://codereview.chromium.org/2571643002

relnote: Remove unused QuicClock member of BbrSender.
Merge internal change: 141366593
https://codereview.chromium.org/2566333002

relnote: Non-functional change. Cleanup pg3 support for quic_packet_reader
Bring it more inline with Chromium source but cleanup the definition of
MMSG_MORE macro to exist in the header so that there's no violation of
ODR for QUicPacketReader class based upon inclusion.
Merge internal change: 141357226
https://codereview.chromium.org/2570703002

relnote: Protected by --quic_fix_cubic_bytes_quantization. Fix CubicBytes
Quantization. iDue to an unfortunate ordering of operations in the actual
"cubing" part of the CWND calculation, we were inadvertantly quantizing the
congestion-window calculation.  (Note: The "reno" part of the cubic algorithm
wis smooth and not quantized before.)  Switching the order of operations
obviates the problem.
Additionally, removed parameterization from cubic_test.cc and
cubic_bytes_test.cc, because the parameterization was getting
unwieldy.  Instead, the parameters are controlled by command-line
flag.
Merge internal change: 141183279
https://codereview.chromium.org/2569873002/

BUG=

Committed: https://crrev.com/1a596c8723eb979ec597e99d27a139cf4e1f6e91
Cr-Commit-Position: refs/heads/master@{#438069}
==========

[commit-bot: I haz the power, 2016-12-13 05:49:09]

Patchset 2 (id:??) landed as
https://crrev.com/1a596c8723eb979ec597e99d27a139cf4e1f6e91
Cr-Commit-Position: refs/heads/master@{#438069}