Issue 2566383002: ObjectGraph: Establish a HeapIterationScope *before* making the heap writable, least the sweeper in…

Issue 2566383002: ObjectGraph: Establish a HeapIterationScope before making the heap writable, least the sweeper in… (Closed)

Created:
4 years ago by rmacnak

Modified:
4 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

ObjectGraph: Establish a HeapIterationScope *before* making the heap writable, least the sweeper interfer. Fixes #28030 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/11975ab353ed458928c298952eaf18dd45c25af5

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -42 lines)			Patch
M	runtime/vm/heap.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View		1 chunk	+24 lines, -13 lines	0 comments	Download
M	runtime/vm/isolate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object_graph.cc	View		12 chunks	+13 lines, -10 lines	0 comments	Download
M	runtime/vm/object_graph_test.cc	View	1	1 chunk	+21 lines, -18 lines	0 comments	Download
M	runtime/vm/service.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

rmacnak

4 years ago (2016-12-14 19:27:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
11975ab353ed458928c298952eaf18dd45c25af5 (presubmit successful).