Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: runtime/vm/heap.h

Issue 2566383002: ObjectGraph: Establish a HeapIterationScope *before* making the heap writable, least the sweeper in… (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.h
diff --git a/runtime/vm/heap.h b/runtime/vm/heap.h
index 3e05e135795910b2202e3edacfe939c17af55bf7..92c201cd8b02ae90c4236ee28370c885f9fd33dd 100644
--- a/runtime/vm/heap.h
+++ b/runtime/vm/heap.h
@@ -350,6 +350,8 @@ class Heap {
friend class Become; // VisitObjectPointers
friend class Precompiler; // VisitObjects
+ friend class ObjectGraph; // VisitObjects
+ friend class Unmarker; // VisitObjects
friend class ServiceEvent;
friend class PageSpace; // VerifyGC
friend class IsolateReloadContext; // VisitObjects
@@ -360,12 +362,13 @@ class Heap {
class HeapIterationScope : public StackResource {
public:
- HeapIterationScope();
+ explicit HeapIterationScope(bool writable = false);
~HeapIterationScope();
private:
NoSafepointScope no_safepoint_scope_;
PageSpace* old_space_;
+ bool writable_;
DISALLOW_COPY_AND_ASSIGN(HeapIterationScope);
};
« no previous file with comments | « no previous file | runtime/vm/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698