Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2566313002: Make OffscreenCanvas commit() propagate the origin-clean flag. (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, dglazkov+blink, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make OffscreenCanvas commit() propagate the origin-clean flag. This change block user code from accessing cross-origin image data from a placeholder canvas. The placeholder code was modified to use StaticBitmapImage instead of Image to gain access to the originClean() method without downcasting. BUG=673348 Committed: https://crrev.com/0eea57f836fb2551563e1f18d5e91215bf0f5150 Cr-Commit-Position: refs/heads/master@{#438172}

Patch Set 1 #

Patch Set 2 : add test #

Messages

Total messages: 20 (13 generated)
Justin Novosad
PTAL
4 years ago (2016-12-12 21:20:51 UTC) #3
Stephen White
LGTM Might want to explain the change from Image to StaticBitmapImage in the CL description.
4 years ago (2016-12-12 22:19:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566313002/20001
4 years ago (2016-12-12 22:45:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/331569)
4 years ago (2016-12-13 01:50:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566313002/20001
4 years ago (2016-12-13 14:53:56 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 15:26:18 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-13 15:28:57 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0eea57f836fb2551563e1f18d5e91215bf0f5150
Cr-Commit-Position: refs/heads/master@{#438172}

Powered by Google App Engine
This is Rietveld 408576698