Issue 2566233002: [Mac] Fixed the content settings bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2566233002: [Mac] Fixed the content settings bubble (Closed)

Created:
4 years ago by spqchan

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, mac-reviews_chromium.org

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 Review-Url: https://codereview.chromium.org/2558443004 Cr-Commit-Position: refs/heads/master@{#436698} (cherry picked from commit cfa3d99e2d870f97146e200f59515a516afda52c) Committed: https://chromium.googlesource.com/chromium/src/+/49341d417f2e84359018a18f21171084a683b55d

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm	View		1 chunk	+13 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

4 years ago (2016-12-12 18:20:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
49341d417f2e84359018a18f21171084a683b55d.