Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558443004:
[Mac] Fixed the content settings bubble (Closed)
Description[Mac] Fixed the content settings bubble
If the user clicks on a content settings icon when the bubble is already
opened, the bubble should close, not open another one
BUG=670621
Committed: https://crrev.com/cfa3d99e2d870f97146e200f59515a516afda52c
Cr-Commit-Position: refs/heads/master@{#436698}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 24 (13 generated)
Description was changed from ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG= ========== to ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 ==========
spqchan@chromium.org changed reviewers: + shrike@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Great! lgtm
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
thanks +avi for ownership
avi@chromium.org changed reviewers: + avi@chromium.org
lgtm https://codereview.chromium.org/2558443004/diff/1/chrome/browser/ui/cocoa/loc... File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right): https://codereview.chromium.org/2558443004/diff/1/chrome/browser/ui/cocoa/loc... chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:310: model, web_contents, origin); Does the bug show in MacViews?
spqchan@chromium.org changed reviewers: - rsesek@chromium.org
On 2016/12/06 20:01:38, Avi (at offsite M-Th) wrote: > lgtm > > https://codereview.chromium.org/2558443004/diff/1/chrome/browser/ui/cocoa/loc... > File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right): > > https://codereview.chromium.org/2558443004/diff/1/chrome/browser/ui/cocoa/loc... > chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:310: model, > web_contents, origin); > Does the bug show in MacViews? Whoops, just realized you're on an offsite. Sorry about that! Anyway, the dialogs don't dismiss on MacViews so it will be fine. Thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/06 20:15:08, spqchan wrote: > Anyway, the dialogs don't dismiss on MacViews so it will be fine. Thanks! You are saying that on MacViews (Views) the dialogs still do the click-the-decoration-and-the-dialog-hides-and-reappears?
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481055314105990, "parent_rev":
"6c41c35c246af1331802c2f274d593684629f9d3", "commit_rev":
"5b15db2d1fb13ed8202e8ba11cceb699eca36a07"}
On 2016/12/06 20:24:13, shrike wrote: > On 2016/12/06 20:15:08, spqchan wrote: > > Anyway, the dialogs don't dismiss on MacViews so it will be fine. Thanks! > > You are saying that on MacViews (Views) the dialogs still do the > click-the-decoration-and-the-dialog-hides-and-reappears? Nope, they are doing the click-the-decoration-and-the-dialog-is-still-there behavior It's doesn't hide and reappear
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 ========== to ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 ========== to ========== [Mac] Fixed the content settings bubble If the user clicks on a content settings icon when the bubble is already opened, the bubble should close, not open another one BUG=670621 Committed: https://crrev.com/cfa3d99e2d870f97146e200f59515a516afda52c Cr-Commit-Position: refs/heads/master@{#436698} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cfa3d99e2d870f97146e200f59515a516afda52c Cr-Commit-Position: refs/heads/master@{#436698}
Message was sent while issue was closed.
On 2016/12/06 20:35:24, spqchan wrote: > On 2016/12/06 20:24:13, shrike wrote: > > On 2016/12/06 20:15:08, spqchan wrote: > > > Anyway, the dialogs don't dismiss on MacViews so it will be fine. Thanks! > > > > You are saying that on MacViews (Views) the dialogs still do the > > click-the-decoration-and-the-dialog-hides-and-reappears? > > Nope, they are doing the click-the-decoration-and-the-dialog-is-still-there > behavior > It's doesn't hide and reappear Same thing. We will want this behavior in (Mac)Views, (and Views generally) - I will file a separate bug for that. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
