Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2566203002: Add a message for Reading List Snackbar (Closed)

Created:
4 years ago by gambard
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a message for Reading List Snackbar BUG=635908 Committed: https://crrev.com/ef1d296698442521f9f0d759cf9336a1e9706dc6 Cr-Commit-Position: refs/heads/master@{#438098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
gambard
PTAL.
4 years ago (2016-12-12 16:43:31 UTC) #2
jif
lgtm
4 years ago (2016-12-12 17:00:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566203002/1
4 years ago (2016-12-12 17:01:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/323777)
4 years ago (2016-12-12 17:46:53 UTC) #10
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-12 23:03:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566203002/1
4 years ago (2016-12-13 08:19:45 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 08:24:11 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 08:26:48 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef1d296698442521f9f0d759cf9336a1e9706dc6
Cr-Commit-Position: refs/heads/master@{#438098}

Powered by Google App Engine
This is Rietveld 408576698