Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2566113002: AudioRendererSinKCache: Do not use unhealthy sinks (Closed)

Created:
4 years ago by o1ka
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

AudioRendererSinKCache: Do not use unhealthy sinks Cache an unused sink only if it is healthy (has an OK status); Get output parameters only from healthy cached sinks. Note that we still can have used sinks in the cache those become unhealthy. BUG=668250, 663546 Review-Url: https://codereview.chromium.org/2533443003 Cr-Commit-Position: refs/heads/master@{#435937} (cherry picked from commit 3e07bf0ac5733215f2b670b42d4cbf90037ea673) TBR=dalecurtis@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2566113002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -71 lines) Patch
M content/renderer/media/audio_renderer_sink_cache_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/media/audio_renderer_sink_cache_impl.cc View 7 chunks +49 lines, -69 lines 0 comments Download
M content/renderer/media/audio_renderer_sink_cache_unittest.cc View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566113002/1
4 years ago (2016-12-12 12:03:14 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-12 12:07:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698