Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6481)

Unified Diff: chrome/browser/component_updater/component_patcher_operation_out_of_process.h

Issue 2566053002: Convert utility process out-of-process file patching to mojo (Closed)
Patch Set: Fix linux_chromium_chromeos_ozone_rel_ng apply patch failure. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_patcher_operation_out_of_process.h
diff --git a/chrome/browser/component_updater/component_patcher_operation_out_of_process.h b/chrome/browser/component_updater/component_patcher_operation_out_of_process.h
index 5500193755977eef8dd9ce86014157fa0d933552..94327b57d80e0795b771c03dfcbb40ccb6fad0d1 100644
--- a/chrome/browser/component_updater/component_patcher_operation_out_of_process.h
+++ b/chrome/browser/component_updater/component_patcher_operation_out_of_process.h
@@ -5,28 +5,19 @@
#ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_PATCHER_OPERATION_OUT_OF_PROCESS_H_
#define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_PATCHER_OPERATION_OUT_OF_PROCESS_H_
-#include <string>
Sam McNally 2016/12/22 02:45:49 These are still needed.
Noel Gordon 2016/12/22 05:06:33 OK, let's do IWYU herein, and remove duplicate #in
-
-#include "base/callback_forward.h"
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
+#include "chrome/common/file_patcher.mojom.h"
#include "components/update_client/component_patcher_operation.h"
-
-namespace base {
-class FilePath;
Sam McNally 2016/12/22 02:45:49 So are these.
Noel Gordon 2016/12/22 05:06:33 Ditto.
-class SequencedTaskRunner;
-} // namespace base
+#include "content/public/browser/utility_process_mojo_client.h"
namespace component_updater {
-class PatchHost;
-
// Implements the DeltaUpdateOpPatch out-of-process patching.
class ChromeOutOfProcessPatcher : public update_client::OutOfProcessPatcher {
public:
ChromeOutOfProcessPatcher();
- // DeltaUpdateOpPatch::OutOfProcessPatcher implementation.
+ // DeltaUpdateOpPatch::OutOfProcessPatcher::Patch() request.
Sam McNally 2016/12/22 02:45:49 This comment should be something of the form updat
Noel Gordon 2016/12/22 05:06:33 // update_client::OutOfProcessPatcher done.
void Patch(const std::string& operation,
scoped_refptr<base::SequencedTaskRunner> task_runner,
const base::FilePath& input_abs_path,
@@ -37,7 +28,16 @@ class ChromeOutOfProcessPatcher : public update_client::OutOfProcessPatcher {
private:
~ChromeOutOfProcessPatcher() override;
- scoped_refptr<PatchHost> host_;
+ // Patch() request operation result.
+ void PatchDone(int result);
+
+ // Used to signal the operation result back to the Patch() requester.
+ scoped_refptr<base::SequencedTaskRunner> task_runner_;
+ base::Callback<void(int result)> callback_;
+
+ // Utility process used for out-of-process file patching.
+ std::unique_ptr<content::UtilityProcessMojoClient<chrome::mojom::FilePatcher>>
+ utility_process_mojo_client_;
DISALLOW_COPY_AND_ASSIGN(ChromeOutOfProcessPatcher);
};

Powered by Google App Engine
This is Rietveld 408576698