Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: chrome/renderer/chrome_render_thread_observer.cc

Issue 2566043004: Add renderer memory metrics (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_thread_observer.cc
diff --git a/chrome/renderer/chrome_render_thread_observer.cc b/chrome/renderer/chrome_render_thread_observer.cc
index 3b96a1577756971a9e423e4953ee1101aaf440de..f35c8bee70a7857d04bed79794dab665a612523f 100644
--- a/chrome/renderer/chrome_render_thread_observer.cc
+++ b/chrome/renderer/chrome_render_thread_observer.cc
@@ -290,6 +290,24 @@ bool ChromeRenderThreadObserver::OnControlMessageReceived(
void ChromeRenderThreadObserver::OnRenderProcessShutdown() {
visited_link_slave_.reset();
+
+ content::RendererMemoryMetrics memory_metrics;
+ content::RenderThread::Get()->GetRendererMemoryMetrics(&memory_metrics);
+ UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.PartitionAllocKB",
+ memory_metrics.partition_alloc_kb);
+ UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.BlinkGCKB",
+ memory_metrics.blink_gc_kb);
+ UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.MallocMB",
+ memory_metrics.malloc_mb);
+ UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.DiscardableKB",
+ memory_metrics.discardable_kb);
+ UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.V8MainThreadIsolateMB",
+ memory_metrics.v8_main_thread_isolate_mb);
+ UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.TotalAllocatedMB",
+ memory_metrics.total_allocated_mb);
+ UMA_HISTOGRAM_MEMORY_MB(
haraken 2016/12/12 11:32:27 I might prefer unifying the units to MB though. It
keishi 2017/01/06 11:08:27 Unified new UMAs to MB. Leaving the existing Purge
+ "Renderer.Memory.Shutdown.NonDiscardableTotalAllocatedMB",
+ memory_metrics.non_discardable_total_allocated_mb);
}
void ChromeRenderThreadObserver::OnFieldTrialGroupFinalized(

Powered by Google App Engine
This is Rietveld 408576698