Add renderer memory metrics

chrome/renderer/chrome_render_thread_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_render_thread_observer.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <memory>
@@ skipping 272 matching lines @@
     IPC_MESSAGE_HANDLER(ChromeViewMsg_SetFieldTrialGroup, OnSetFieldTrialGroup)
     IPC_MESSAGE_HANDLER(ChromeViewMsg_SetContentSettingRules,
                         OnSetContentSettingRules)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ChromeRenderThreadObserver::OnRenderProcessShutdown() {
   visited_link_slave_.reset();
+
+  content::RendererMemoryMetrics memory_metrics;
+  content::RenderThread::Get()->GetRendererMemoryMetrics(&memory_metrics);
+  UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.PartitionAllocKB",
+                          memory_metrics.partition_alloc_kb);
+  UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.BlinkGCKB",
+                          memory_metrics.blink_gc_kb);
+  UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.MallocMB",
+                          memory_metrics.malloc_mb);
+  UMA_HISTOGRAM_MEMORY_KB("Renderer.Memory.Shutdown.DiscardableKB",
+                          memory_metrics.discardable_kb);
+  UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.V8MainThreadIsolateMB",
+                          memory_metrics.v8_main_thread_isolate_mb);
+  UMA_HISTOGRAM_MEMORY_MB("Renderer.Memory.Shutdown.TotalAllocatedMB",
+                          memory_metrics.total_allocated_mb);
+  UMA_HISTOGRAM_MEMORY_MB(

[haraken, 2016/12/12 11:32:27]

I might prefer unifying the units to MB though. It's confusing some allocators
report MB whereas others report KB.

[keishi, 2017/01/06 11:08:27]

Unified new UMAs to MB. Leaving the existing PurgeAndSuspend UMAs as is because
we don't want to split the data.

+      "Renderer.Memory.Shutdown.NonDiscardableTotalAllocatedMB",
+      memory_metrics.non_discardable_total_allocated_mb);
 }
 
 void ChromeRenderThreadObserver::OnFieldTrialGroupFinalized(
     const std::string& trial_name,
     const std::string& group_name) {
   chrome::mojom::FieldTrialRecorderPtr field_trial_recorder;
   content::RenderThread::Get()->GetRemoteInterfaces()->GetInterface(
       &field_trial_recorder);
   field_trial_recorder->FieldTrialActivated(trial_name);
 }
@@ skipping 11 matching lines @@
 void ChromeRenderThreadObserver::OnSetFieldTrialGroup(
     const std::string& trial_name,
     const std::string& group_name) {
   field_trial_syncer_.OnSetFieldTrialGroup(trial_name, group_name);
 }
 
 const RendererContentSettingRules*
 ChromeRenderThreadObserver::content_setting_rules() const {
   return &content_setting_rules_;
 }