Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2566043003: Add new RuntimeEnabledFeature: IdleTimeSpellChecking (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new RuntimeEnabledFeature: IdleTimeSpellChecking As the first step of implementing Idle Time Spell Checker, this patch adds a new runtime enabled feature IdleTimeSpellChecking, and exits the existing spell-checking code paths when the feature is enabled. BUG=671922 Committed: https://crrev.com/3e22c3a8af02da09eb1c226b7d3e61c04c16ae45 Cr-Commit-Position: refs/heads/master@{#437840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 6 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-12 06:37:51 UTC) #6
tkent
lgtm
4 years ago (2016-12-12 06:39:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566043003/1
4 years ago (2016-12-12 06:48:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 10:09:59 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e22c3a8af02da09eb1c226b7d3e61c04c16ae45
Cr-Commit-Position: refs/heads/master@{#437840}

Powered by Google App Engine
This is Rietveld 408576698