Implicit prefinalizer registration.

Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645
Committed: https://crrev.com/bc86f5fb6fa58808c4d7937b6279e89d977b6b69
Cr-Commit-Position: refs/heads/master@{#438110}

[sof, 2016-12-11 13:06:05]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 13:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 13:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 13:39:10]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sof, 2016-12-11 17:12:25]

Description was changed from

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer. It has not proven
to have uses.

R=
BUG=
==========

to

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=
BUG=
==========

[sof, 2016-12-11 17:16:10]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:16:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-12-11 17:37:18]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-12-11 17:40:36]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 19:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 19:29:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sof, 2016-12-11 19:36:03]

sigbjornf@opera.com changed reviewers:
+ junov@chromium.org, kbr@chromium.org, oilpan-reviews@chromium.org

[sof, 2016-12-11 19:36:04]

please take a look.

The prefinalizer for HTMLCanvasElement is enabled here. i.e., r399587 wasn't
effective. Which sort of motivates this change, we're taxing developers
unnecessarily by having to remember this manual registration step.

( I'd be happy to split out the canvas change and land a (short-lived)
registerPreFinalizer() call in its ctor first, if considered preferable. )

[haraken, 2016-12-12 00:51:08]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-12-12 00:51:09]

LGTM

[sof, 2016-12-12 07:15:29]

Description was changed from

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=
BUG=
==========

to

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=
==========

[sof, 2016-12-12 07:15:34]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-12-12 07:15:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-12-12 07:18:30]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2016-12-12 07:37:41]

Out of the 40+ classes that use prefinalizers, Animation is an outlier. It
conditionally registers its prefinalizer at run-time.

I need to determine how (and if) to handle that instance with this model.

[Justin Novosad, 2016-12-12 15:19:05]

lgtm

[sof, 2016-12-12 15:22:54]

On 2016/12/12 07:37:41, sof wrote:
> Out of the 40+ classes that use prefinalizers, Animation is an outlier. It
> conditionally registers its prefinalizer at run-time.
> 
> I need to determine how (and if) to handle that instance with this model.

Will land https://codereview.chromium.org/2570503002/ first, so that we don't
register more prefinalizers than necessary.

[sof, 2016-12-12 21:56:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-12-12 21:58:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 00:26:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:26:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Russell (switch to Gerrit), 2016-12-13 01:26:09]

Looks fine. I would suggest you file a bug about this and reference it from both
of these CLs so that in case they provoke flaky crashes there's a central place
to track them.

[sof, 2016-12-13 06:31:50]

Description was changed from

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=
==========

to

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645
==========

[sof, 2016-12-13 06:32:06]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-12-13 06:32:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 09:28:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481610726465510,
"parent_rev": "2d7abb78d11d16d614265216e8bab6b3fde28672", "commit_rev":
"41de4dc7a580071571d90a9e3524f2e4968ac436"}

[commit-bot: I haz the power, 2016-12-13 09:29:29]

Description was changed from

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645
==========

to

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645

Review-Url: https://codereview.chromium.org/2565983002
==========

[commit-bot: I haz the power, 2016-12-13 09:29:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 09:32:04]

Description was changed from

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645

Review-Url: https://codereview.chromium.org/2565983002
==========

to

==========
Implicit prefinalizer registration.

Switch to implicit registration of prefinalizers along with removing
the ability to dynamically unregister a prefinalizer; the latter
being an unused feature.

The requirement to manually register a prefinalizer has proven to be
a chore and a source of bugs. Case in point: HTMLCanvasElement
currently declares a prefinalizer, but doesn't register it. Simplify
the programming model by automatically registering prefinalizers.

R=haraken
BUG=673645

Committed: https://crrev.com/bc86f5fb6fa58808c4d7937b6279e89d977b6b69
Cr-Commit-Position: refs/heads/master@{#438110}
==========

[commit-bot: I haz the power, 2016-12-13 09:32:05]

Patchset 4 (id:??) landed as
https://crrev.com/bc86f5fb6fa58808c4d7937b6279e89d977b6b69
Cr-Commit-Position: refs/heads/master@{#438110}