Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2565873002: [translate] Add translate ranker model loader. (Closed)
Patch Set: Address comments from groby, fdoray, hamelphi Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate_unittest.cc
diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc
index b63cbd6d57097a27460a5565b2502f00bb037db0..71721fa0e32c5a32ddc6eb923f6faf8ee6fc4f25 100644
--- a/components/translate/core/browser/translate_ui_delegate_unittest.cc
+++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc
@@ -14,6 +14,7 @@
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "components/translate/core/browser/mock_translate_driver.h"
+#include "components/translate/core/browser/mock_translate_ranker.h"
#include "components/translate/core/browser/translate_client.h"
#include "components/translate/core/browser/translate_infobar_delegate.h"
#include "components/translate/core/browser/translate_manager.h"
@@ -26,6 +27,7 @@
using testing::Return;
using testing::Test;
using translate::testing::MockTranslateDriver;
+using translate::testing::MockTranslateRanker;
namespace translate {
@@ -85,8 +87,8 @@ class TranslateUIDelegateTest : public ::testing::Test {
TranslatePrefs::RegisterProfilePrefs(pref_service_->registry());
client_.reset(new MockTranslateClient(&driver_, pref_service_.get()));
-
- manager_.reset(new TranslateManager(client_.get(), "hi"));
+ ranker_.reset(new MockTranslateRanker());
+ manager_.reset(new TranslateManager(client_.get(), ranker_.get(), "hi"));
manager_->GetLanguageState().set_translation_declined(false);
delegate_.reset(
@@ -97,6 +99,7 @@ class TranslateUIDelegateTest : public ::testing::Test {
MockTranslateDriver driver_;
std::unique_ptr<MockTranslateClient> client_;
+ std::unique_ptr<MockTranslateRanker> ranker_;
groby-ooo-7-16 2017/02/23 00:01:35 Might want to add a comment to please not reorder,
Roger McFarlane (Chromium) 2017/02/23 21:17:56 Indeed. Actually, I think they were in the wrong
std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_;
std::unique_ptr<TranslateManager> manager_;
std::unique_ptr<TranslateUIDelegate> delegate_;

Powered by Google App Engine
This is Rietveld 408576698