Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2565873002: [translate] Add translate ranker model loader. (Closed)
Patch Set: Address comments from groby, fdoray, hamelphi Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ui_delegate.h" 5 #include "components/translate/core/browser/translate_ui_delegate.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "build/build_config.h" 12 #include "build/build_config.h"
13 #include "components/infobars/core/infobar.h" 13 #include "components/infobars/core/infobar.h"
14 #include "components/pref_registry/pref_registry_syncable.h" 14 #include "components/pref_registry/pref_registry_syncable.h"
15 #include "components/sync_preferences/testing_pref_service_syncable.h" 15 #include "components/sync_preferences/testing_pref_service_syncable.h"
16 #include "components/translate/core/browser/mock_translate_driver.h" 16 #include "components/translate/core/browser/mock_translate_driver.h"
17 #include "components/translate/core/browser/mock_translate_ranker.h"
17 #include "components/translate/core/browser/translate_client.h" 18 #include "components/translate/core/browser/translate_client.h"
18 #include "components/translate/core/browser/translate_infobar_delegate.h" 19 #include "components/translate/core/browser/translate_infobar_delegate.h"
19 #include "components/translate/core/browser/translate_manager.h" 20 #include "components/translate/core/browser/translate_manager.h"
20 #include "components/translate/core/browser/translate_prefs.h" 21 #include "components/translate/core/browser/translate_prefs.h"
21 #include "components/variations/variations_associated_data.h" 22 #include "components/variations/variations_associated_data.h"
22 #include "testing/gmock/include/gmock/gmock.h" 23 #include "testing/gmock/include/gmock/gmock.h"
23 #include "testing/gtest/include/gtest/gtest.h" 24 #include "testing/gtest/include/gtest/gtest.h"
24 #include "url/gurl.h" 25 #include "url/gurl.h"
25 26
26 using testing::Return; 27 using testing::Return;
27 using testing::Test; 28 using testing::Test;
28 using translate::testing::MockTranslateDriver; 29 using translate::testing::MockTranslateDriver;
30 using translate::testing::MockTranslateRanker;
29 31
30 namespace translate { 32 namespace translate {
31 33
32 #if defined(OS_CHROMEOS) 34 #if defined(OS_CHROMEOS)
33 const char* preferred_languages_prefs = "settings.language.preferred_languages"; 35 const char* preferred_languages_prefs = "settings.language.preferred_languages";
34 #else 36 #else
35 const char* preferred_languages_prefs = NULL; 37 const char* preferred_languages_prefs = NULL;
36 #endif 38 #endif
37 39
38 class MockTranslateClient : public TranslateClient { 40 class MockTranslateClient : public TranslateClient {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 80
79 void SetUp() override { 81 void SetUp() override {
80 pref_service_.reset(new sync_preferences::TestingPrefServiceSyncable()); 82 pref_service_.reset(new sync_preferences::TestingPrefServiceSyncable());
81 pref_service_->registry()->RegisterStringPref( 83 pref_service_->registry()->RegisterStringPref(
82 "settings.language.preferred_languages", std::string()); 84 "settings.language.preferred_languages", std::string());
83 pref_service_->registry()->RegisterStringPref("intl.accept_languages", 85 pref_service_->registry()->RegisterStringPref("intl.accept_languages",
84 std::string()); 86 std::string());
85 TranslatePrefs::RegisterProfilePrefs(pref_service_->registry()); 87 TranslatePrefs::RegisterProfilePrefs(pref_service_->registry());
86 88
87 client_.reset(new MockTranslateClient(&driver_, pref_service_.get())); 89 client_.reset(new MockTranslateClient(&driver_, pref_service_.get()));
88 90 ranker_.reset(new MockTranslateRanker());
89 manager_.reset(new TranslateManager(client_.get(), "hi")); 91 manager_.reset(new TranslateManager(client_.get(), ranker_.get(), "hi"));
90 manager_->GetLanguageState().set_translation_declined(false); 92 manager_->GetLanguageState().set_translation_declined(false);
91 93
92 delegate_.reset( 94 delegate_.reset(
93 new TranslateUIDelegate(manager_->GetWeakPtr(), "ar", "fr")); 95 new TranslateUIDelegate(manager_->GetWeakPtr(), "ar", "fr"));
94 96
95 ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar")); 97 ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar"));
96 } 98 }
97 99
98 MockTranslateDriver driver_; 100 MockTranslateDriver driver_;
99 std::unique_ptr<MockTranslateClient> client_; 101 std::unique_ptr<MockTranslateClient> client_;
102 std::unique_ptr<MockTranslateRanker> ranker_;
groby-ooo-7-16 2017/02/23 00:01:35 Might want to add a comment to please not reorder,
Roger McFarlane (Chromium) 2017/02/23 21:17:56 Indeed. Actually, I think they were in the wrong
100 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_; 103 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> pref_service_;
101 std::unique_ptr<TranslateManager> manager_; 104 std::unique_ptr<TranslateManager> manager_;
102 std::unique_ptr<TranslateUIDelegate> delegate_; 105 std::unique_ptr<TranslateUIDelegate> delegate_;
103 106
104 private: 107 private:
105 DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest); 108 DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest);
106 }; 109 };
107 110
108 TEST_F(TranslateUIDelegateTest, CheckDeclinedFalse) { 111 TEST_F(TranslateUIDelegateTest, CheckDeclinedFalse) {
109 std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs()); 112 std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 prefs->IncrementTranslationAcceptedCount("ar"); 199 prefs->IncrementTranslationAcceptedCount("ar");
197 200
198 EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault()); 201 EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault());
199 } 202 }
200 203
201 // TODO(ftang) Currently this file only test TranslationDeclined(), we 204 // TODO(ftang) Currently this file only test TranslationDeclined(), we
202 // need to add the test for other functions soon to increase the test 205 // need to add the test for other functions soon to increase the test
203 // coverage. 206 // coverage.
204 207
205 } // namespace translate 208 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698