Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2565863002: IntersectionObserver: use post task inside of resume(). (Closed)

Created:
4 years ago by szager1
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: use post task inside of resume(). Rather than running callbacks immediately, post a task to run the callbacks, to avoid conflicts while undeferring a page. R=dcheng@chromium.org BUG=670092 Committed: https://crrev.com/389cf84d79f9dd6d2d7ad49cce34e9e38b578804 Cr-Commit-Position: refs/heads/master@{#438043}

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp View 1 2 chunks +60 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
szager1
4 years ago (2016-12-09 21:34:08 UTC) #1
dcheng
Change looks reasonable to me; is there any way to test it?
4 years ago (2016-12-09 23:03:11 UTC) #2
szager1
On 2016/12/09 23:03:11, dcheng wrote: > Change looks reasonable to me; is there any way ...
4 years ago (2016-12-13 01:15:26 UTC) #3
dcheng
lgtm https://codereview.chromium.org/2565863002/diff/20001/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp File third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp (right): https://codereview.chromium.org/2565863002/diff/20001/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp#newcode93 third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp:93: testing::runPendingTasks(); Just to make sure I understand: is ...
4 years ago (2016-12-13 01:35:37 UTC) #4
szager1
https://codereview.chromium.org/2565863002/diff/20001/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp File third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp (right): https://codereview.chromium.org/2565863002/diff/20001/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp#newcode93 third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp:93: testing::runPendingTasks(); On 2016/12/13 01:35:36, dcheng wrote: > Just to ...
4 years ago (2016-12-13 01:40:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565863002/20001
4 years ago (2016-12-13 01:41:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:50:44 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 03:54:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/389cf84d79f9dd6d2d7ad49cce34e9e38b578804
Cr-Commit-Position: refs/heads/master@{#438043}

Powered by Google App Engine
This is Rietveld 408576698