Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2565853003: media: Rename CdmService to CdmRegistry (Closed)

Created:
4 years ago by xhwang
Modified:
4 years ago
Reviewers:
waffles, jrummell, nasko
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Rename CdmService to CdmRegistry TBR=nasko@chromium.org,waffles@chromium.org BUG=672652 Committed: https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b Cr-Commit-Position: refs/heads/master@{#438091}

Patch Set 1 : move #

Patch Set 2 : rename #

Patch Set 3 : add missing BUILD.gn entry #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -277 lines) Patch
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A content/browser/media/cdm_registry_impl.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
A + content/browser/media/cdm_registry_impl.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + content/browser/media/cdm_registry_impl_unittest.cc View 1 6 chunks +14 lines, -14 lines 0 comments Download
D content/browser/media/cdm_service_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/media/cdm_service_impl.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/media/cdm_service_impl_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 2 comments Download
A + content/public/browser/cdm_registry.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
D content/public/browser/cdm_service.h View 1 chunk +0 lines, -42 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (16 generated)
xhwang
4 years ago (2016-12-10 01:53:42 UTC) #8
xhwang
jrummell: PTAL
4 years ago (2016-12-10 01:53:55 UTC) #9
jrummell
lgtm
4 years ago (2016-12-12 22:12:07 UTC) #12
xhwang
TBRing waffles@ on changes in chrome/browser/component_updater/widevine_cdm_component_installer.cc TBRing nasko@ on content/* changes. This is a trivial ...
4 years ago (2016-12-12 22:48:50 UTC) #16
waffles
component_updater lgtm
4 years ago (2016-12-12 23:14:03 UTC) #17
nasko
content/ LGTM with a nit. https://codereview.chromium.org/2565853003/diff/40001/content/public/browser/BUILD.gn File content/public/browser/BUILD.gn (right): https://codereview.chromium.org/2565853003/diff/40001/content/public/browser/BUILD.gn#newcode76 content/public/browser/BUILD.gn:76: "cdm_registry.h", nit: This didn't ...
4 years ago (2016-12-12 23:25:16 UTC) #18
xhwang
https://codereview.chromium.org/2565853003/diff/40001/content/public/browser/BUILD.gn File content/public/browser/BUILD.gn (right): https://codereview.chromium.org/2565853003/diff/40001/content/public/browser/BUILD.gn#newcode76 content/public/browser/BUILD.gn:76: "cdm_registry.h", On 2016/12/12 23:25:16, nasko (very slow til Dec ...
4 years ago (2016-12-12 23:34:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565853003/40001
4 years ago (2016-12-13 06:02:40 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 07:14:02 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-13 07:18:02 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ba56be620975f8da04659f7df4c91ec7d88579b
Cr-Commit-Position: refs/heads/master@{#438091}

Powered by Google App Engine
This is Rietveld 408576698