Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2565833002: Uses |AXPosition| to enable navigation by character, word and line in content editables on the Mac. (Closed)

Created:
4 years ago by nektarios
Modified:
4 years ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uses |AXPosition| to enable navigation by character, word and line in content editables on the Mac. Preliminary BUG=530826 R=dmazzoni@chromium.org, ellyjones@chromium.org TESTED=not tested yet Committed: https://crrev.com/8739efe51143dc140b21ee05a45684a033464bc6 Cr-Commit-Position: refs/heads/master@{#439978}

Patch Set 1 #

Patch Set 2 : Used another undocumented function. #

Patch Set 3 : Removed the use of AXTextMarkerGetBytes. #

Patch Set 4 : Added missing include. #

Patch Set 5 : Converted unordered text markers to use AXPosition. #

Patch Set 6 : Fixed all compilation errors. #

Patch Set 7 : Fixed AXRange::GetText. #

Patch Set 8 : Added more logging. #

Patch Set 9 : Fixed some boundary errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -320 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 7 8 13 chunks +177 lines, -305 lines 0 comments Download
M ui/accessibility/ax_node_position_unittest.cc View 1 2 3 4 5 6 7 2 chunks +19 lines, -1 line 0 comments Download
M ui/accessibility/ax_position.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_range.h View 1 2 3 4 5 6 7 8 2 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Elly Fong-Jones
lgtm
4 years ago (2016-12-09 20:23:28 UTC) #1
nektarios
I'll be working through any bugs during the next few days.
4 years ago (2016-12-10 02:39:51 UTC) #4
dmazzoni
lgtm
4 years ago (2016-12-12 18:33:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565833002/160001
4 years ago (2016-12-21 00:49:39 UTC) #12
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years ago (2016-12-21 02:07:29 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-21 02:09:58 UTC) #17
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/8739efe51143dc140b21ee05a45684a033464bc6
Cr-Commit-Position: refs/heads/master@{#439978}

Powered by Google App Engine
This is Rietveld 408576698