Reland: Add test for system tray network menu icon for extension-controlled networks

Reland: Add test for system tray network menu icon for extension-controlled networks

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests

Committed: https://crrev.com/4b7224833d7a739afb2cb1758a2acbe6509d12cc
Cr-Commit-Position: refs/heads/master@{#437627}

[James Cook, 2016-12-09 17:53:02]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 17:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-09 17:54:19]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-12-09 17:54:20]

Steven, please take a look. It turns out a test cannot just create its own tray
detailed view -- you have to use the real one. This is a slightly better
integration test anyhow. Differences between patchsets 1 and 2 are the fix.

[James Cook, 2016-12-09 17:54:50]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-12-09 17:55:40]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 17:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-12-09 17:58:25]

Ah, right. I knew that was too easy :)

Thanks for uploading the baseline.

LGTM

[James Cook, 2016-12-09 17:59:50]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-12-09 17:59:56]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:35:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481306396992930,
"parent_rev": "8ceae57dde3ae402d70f88d4142e34fe0c9fff3b", "commit_rev":
"f6dd7a85222f60d6b3f298a9597a5d57835b5e02"}

[commit-bot: I haz the power, 2016-12-09 20:35:39]

Description was changed from

==========
Reland: Add test for system tray network menu icon for extension-controlled
networks

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests
==========

to

==========
Reland: Add test for system tray network menu icon for extension-controlled
networks

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests

Review-Url: https://codereview.chromium.org/2565823002
==========

[commit-bot: I haz the power, 2016-12-09 20:35:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:39:54]

Description was changed from

==========
Reland: Add test for system tray network menu icon for extension-controlled
networks

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests

Review-Url: https://codereview.chromium.org/2565823002
==========

to

==========
Reland: Add test for system tray network menu icon for extension-controlled
networks

Original CL http://crrev.com/2558083003 was reverted for use-after-free
caused by my test network detailed view registering observers that were
not properly cleaned up. Switched to using the real system menu network
detailed view.

Eventually extension-controlled network information will come out of a mojo
service. This provides test coverage to make sure the icon shows up in the
system tray menu.

BUG=651157
TEST=chrome browser_tests

Committed: https://crrev.com/4b7224833d7a739afb2cb1758a2acbe6509d12cc
Cr-Commit-Position: refs/heads/master@{#437627}
==========

[commit-bot: I haz the power, 2016-12-12 14:39:55]

Patchset 2 (id:??) landed as
https://crrev.com/4b7224833d7a739afb2cb1758a2acbe6509d12cc
Cr-Commit-Position: refs/heads/master@{#437627}