Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2565813002: Create c/b/ui/cocoa/test and move test files to there (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
Reviewers:
Robert Sesek, sky
CC:
chromium-reviews, asanka, chromium-apps-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, dcheng, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, James Su, dbeam+watch-downloads_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create c/b/ui/cocoa/test and move test files to there From discussion at https://crrev.com/2555033003/#msg21 BUG= Committed: https://crrev.com/92aad3c0c15d18263af3e5ce0dad525c0b063297 Cr-Commit-Position: refs/heads/master@{#437707}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix find/replace fail #

Patch Set 3 : Update header guards #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -618 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/animatable_image_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/animatable_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/menu_tracked_root_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_pop_up_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_textfield_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/background_gradient_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bubble_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_browser_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/cocoa_profile_test.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/ui/cocoa/cocoa_test_helper.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/cocoa/cocoa_test_helper.mm View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_util_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/draggable_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_pasteboard_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/floating_bar_backing_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_separator_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/cocoa/run_loop_testing.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/cocoa/run_loop_testing.mm View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/cocoa/run_loop_testing_unittest.mm View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/sprite_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_cell_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/cocoa/styled_text_field_test_helper.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/cocoa/styled_text_field_test_helper.mm View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/test/cocoa_profile_test.h View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/cocoa_profile_test.mm View 2 chunks +2 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/cocoa_test_helper.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/cocoa_test_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/test/run_loop_testing.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/run_loop_testing.mm View 2 chunks +2 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/run_loop_testing_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/test/styled_text_field_test_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/test/styled_text_field_test_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/url_drop_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/vertical_gradient_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tests/ui_gfx_image_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
lgrey
PTAL :)
4 years ago (2016-12-09 18:50:49 UTC) #4
Robert Sesek
https://codereview.chromium.org/2565813002/diff/1/chrome/browser/ui/cocoa/test/cocoa_test_helper.h File chrome/browser/ui/cocoa/test/cocoa_test_helper.h (right): https://codereview.chromium.org/2565813002/diff/1/chrome/browser/ui/cocoa/test/cocoa_test_helper.h#newcode5 chrome/browser/ui/cocoa/test/cocoa_test_helper.h:5: #ifndef CHROME_BROWSER_UI_COCOA_COCOA_TEST_HELPER_H_ Please also update the include guards to ...
4 years ago (2016-12-09 18:58:46 UTC) #5
lgrey
On 2016/12/09 18:58:46, Robert Sesek wrote: > https://codereview.chromium.org/2565813002/diff/1/chrome/browser/ui/cocoa/test/cocoa_test_helper.h > File chrome/browser/ui/cocoa/test/cocoa_test_helper.h (right): > > https://codereview.chromium.org/2565813002/diff/1/chrome/browser/ui/cocoa/test/cocoa_test_helper.h#newcode5 ...
4 years ago (2016-12-09 19:15:17 UTC) #6
Robert Sesek
LGTM
4 years ago (2016-12-09 19:32:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565813002/30001
4 years ago (2016-12-09 19:37:02 UTC) #9
lgrey
Thanks! sky@ PTAL for chrome/browser/ui
4 years ago (2016-12-09 19:38:59 UTC) #12
sky
LGTM
4 years ago (2016-12-09 21:01:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565813002/30001
4 years ago (2016-12-09 21:29:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565813002/50001
4 years ago (2016-12-09 21:58:43 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years ago (2016-12-10 01:22:53 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:03 UTC) #23
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/92aad3c0c15d18263af3e5ce0dad525c0b063297
Cr-Commit-Position: refs/heads/master@{#437707}

Powered by Google App Engine
This is Rietveld 408576698