Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2565743004: Remove the CNNIC whitelist (Closed)

Created:
4 years ago by Ryan Sleevi
Modified:
4 years ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, awhalley
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the CNNIC whitelist The CNNIC whitelist was temporary, and only contained EE certs. Remove the whitelist, fully distrusting CNNIC. BUG=673083 Committed: https://crrev.com/d921e149bf9a405d9952e40e12085d4bc3814e8a Cr-Commit-Position: refs/heads/master@{#437935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1811 lines) Patch
M net/cert/cert_verify_proc_blacklist.inc View 3 chunks +9 lines, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist.h View 2 chunks +0 lines, -15 lines 0 comments Download
M net/cert/cert_verify_proc_whitelist.cc View 2 chunks +0 lines, -1625 lines 0 comments Download
M net/cert/cert_verify_proc_whitelist_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
A net/data/ssl/blacklist/1c01c6f4dbb2fefc22558b2bca32563f49844acfc32b7be4b0ff599f9e8c7af7.pem View 1 chunk +24 lines, -0 lines 0 comments Download
M net/data/ssl/blacklist/README.md View 1 chunk +11 lines, -0 lines 0 comments Download
A net/data/ssl/blacklist/e28393773da845a679f2080cc7fb44a3b7a1c3792cb7eb7729fdcb6a8d99aea7.pem View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Ryan Sleevi
David: For your review
4 years ago (2016-12-10 03:08:56 UTC) #3
davidben
lgtm
4 years ago (2016-12-12 19:15:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565743004/1
4 years ago (2016-12-12 19:31:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:40:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 22:42:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d921e149bf9a405d9952e40e12085d4bc3814e8a
Cr-Commit-Position: refs/heads/master@{#437935}

Powered by Google App Engine
This is Rietveld 408576698